From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2891EC433DF for ; Mon, 18 May 2020 21:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA55920715 for ; Mon, 18 May 2020 21:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="kqK+2SMM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgERVJn (ORCPT ); Mon, 18 May 2020 17:09:43 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:19808 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgERVJn (ORCPT ); Mon, 18 May 2020 17:09:43 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1589836182; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Re0ZEHG/1Qk293ExAqf/tCdY7EItDCGUUL1ATY2RE5A=; b=kqK+2SMMnfIjkixTYh0znEiGWXggOVq7n9Oe3y7WM3599IKzL0F+pX4uU+4E3VWs1BucKcbc K0gw5+KRwaYCBpW6gUZo4nI94wOSL7oLT/Ixi2x6qpywavWBrwla6BVpiggC+GwUueQ/0hyF VAziHlHD0bwVvquhC1dKSb4yUtg= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3ZjU0NiIsICJsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ec2f996.7f128707f1f0-smtp-out-n05; Mon, 18 May 2020 21:09:42 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 15EE3C44788; Mon, 18 May 2020 21:09:42 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: majja) by smtp.codeaurora.org (Postfix) with ESMTPSA id E3325C433F2; Mon, 18 May 2020 21:09:40 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 18 May 2020 14:09:40 -0700 From: majja@codeaurora.org To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, paul.kocialkowski@bootlin.com, p.zabel@pengutronix.de, ezequiel@collabora.com, jonas@kwiboo.se, boris.brezillon@collabora.com, posciak@chromium.org, ribalda@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, sumitg@nvidia.com Subject: Re: [PATCH] media: v4l2-ctrls: Add encoded frame quality controls In-Reply-To: <1589836035-16579-1-git-send-email-majja@codeaurora.org> References: <1589836035-16579-1-git-send-email-majja@codeaurora.org> Message-ID: <11481ef8fcee02aba17ef527c56c78d2@codeaurora.org> X-Sender: majja@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, Regarding below patch - HEIF/HEIC image encoding uses HEVC/AVC encoders and client can set image quality level using V4L2_CID_MPEG_VIDEO_FRAME_QUALITY control. Reference BITRATE_MODE_CQ at https://developer.android.com/reference/android/media/MediaCodecInfo.EncoderCapabilities#BITRATE_MODE_CQ Regards, Maheshwar. On 2020-05-18 14:07, Maheshwar Ajja wrote: > When frame quality control is enabled encoder will choose > the appropriate quantization parameter and bitrate to > produce the client requested frame quality level. > When frame quality control is disabled then frame quality > is decided based on appropriate controls (i.e. > V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE and/or > V4L2_CID_MPEG_VIDEO_BITRATE_MODE) > > Signed-off-by: Maheshwar Ajja > --- > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 16 > ++++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ > include/uapi/linux/v4l2-controls.h | 2 ++ > 3 files changed, 21 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > index d0d506a..495b39b 100644 > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > @@ -1081,6 +1081,22 @@ enum v4l2_mpeg_video_h264_entropy_mode - > Macroblock level rate control enable. Applicable to the MPEG4 and > H264 encoders. > > +``V4L2_CID_MPEG_VIDEO_FRAME_QUALITY_ENABLE (boolean)`` > + Encoded frame quality control enable. If this control is enabled > then > + the quality level of the encoded frame is set with control > + ``V4L2_CID_MPEG_VIDEO_CONSTANT_QUALITY``. If this control is > disabled > + then the quality level of encoded frame is adjusted with > appropriate > + controls (e.g. ``V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE`` or > + ``V4L2_CID_MPEG_VIDEO_BITRATE_MODE``). Applicable to encoders. > + > +``V4L2_CID_MPEG_VIDEO_FRAME_QUALITY (integer)`` > + Encoded frame quality control. If the control > + ``V4L2_CID_MPEG_VIDEO_FRAME_QUALITY_ENABLE`` is enabled then the > + quality of encoded frame is set with this control. Valid range is > 1 to > + 100 where 1 indicates lowest quality and 100 indicates highest > quality. > + Encoder will decide the appropriate quantization parameter and > bitrate > + to produce requested frame quality. Applicable to encoders. > + > ``V4L2_CID_MPEG_VIDEO_MPEG4_QPEL (boolean)`` > Quarter pixel motion estimation for MPEG4. Applicable to the MPEG4 > encoder. > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c > b/drivers/media/v4l2-core/v4l2-ctrls.c > index 1c617b4..1477198 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -982,6 +982,8 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_MPEG_VIDEO_HEVC_SLICE_PARAMS: return "HEVC Slice > Parameters"; > case V4L2_CID_MPEG_VIDEO_HEVC_DECODE_MODE: return "HEVC Decode > Mode"; > case V4L2_CID_MPEG_VIDEO_HEVC_START_CODE: return "HEVC Start Code"; > + case V4L2_CID_MPEG_VIDEO_FRAME_QUALITY_ENABLE: return "Frame Quality > Enable"; > + case V4L2_CID_MPEG_VIDEO_FRAME_QUALITY: return "Frame Quality"; > > /* CAMERA controls */ > /* Keep the order of the 'case's the same as in v4l2-controls.h! */ > @@ -1178,6 +1180,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, > enum v4l2_ctrl_type *type, > case V4L2_CID_FLASH_READY: > case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER: > case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE: > + case V4L2_CID_MPEG_VIDEO_FRAME_QUALITY_ENABLE: > case V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_MB_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM: > diff --git a/include/uapi/linux/v4l2-controls.h > b/include/uapi/linux/v4l2-controls.h > index 0ba1005..d97a934 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -742,6 +742,8 @@ enum v4l2_cid_mpeg_video_hevc_size_of_length_field > { > #define V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_BR (V4L2_CID_MPEG_BASE > + 642) > #define V4L2_CID_MPEG_VIDEO_REF_NUMBER_FOR_PFRAMES (V4L2_CID_MPEG_BASE > + 643) > #define V4L2_CID_MPEG_VIDEO_PREPEND_SPSPPS_TO_IDR (V4L2_CID_MPEG_BASE > + 644) > +#define V4L2_CID_MPEG_VIDEO_FRAME_QUALITY_ENABLE (V4L2_CID_MPEG_BASE + > 645) > +#define V4L2_CID_MPEG_VIDEO_FRAME_QUALITY (V4L2_CID_MPEG_BASE + 646) > > /* MPEG-class control IDs specific to the CX2341x driver as defined > by V4L2 */ > #define V4L2_CID_MPEG_CX2341X_BASE (V4L2_CTRL_CLASS_MPEG | 0x1000)