From: Bastien Nocera <hadess@hadess.net>
To: Sean Young <sean@mess.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v3] keytable: Add keymap test
Date: Mon, 01 Jul 2019 15:54:11 +0200 [thread overview]
Message-ID: <120d0c8ca8a1297a1b25def5a25e7b41b2dd4bdc.camel@hadess.net> (raw)
In-Reply-To: <20190701112850.m34otmvd5nhxvirb@gofer.mess.org>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On Mon, 2019-07-01 at 12:28 +0100, Sean Young wrote:
> On Fri, Jun 28, 2019 at 11:45:29AM +0200, Bastien Nocera wrote:
> > This new test will try to parse all the ".toml" files in the
> > directory
> > path passed to it, error'ing out on the first parsing problem.
> >
> > Run as "make check" in the keytable directory.
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > Changes since v2:
> > - Added SoB
>
> What about the other comments?
Please mention as early as possible in your review mails that there's
more comments below. I can't guess that from the mail you sent, see the
screenshot attached.
[-- Attachment #2: review-mail.png --]
[-- Type: image/png, Size: 65592 bytes --]
next prev parent reply other threads:[~2019-07-01 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 9:45 [PATCH v3] keytable: Add keymap test Bastien Nocera
2019-07-01 11:28 ` Sean Young
2019-07-01 13:54 ` Bastien Nocera [this message]
2019-07-04 13:24 Bastien Nocera
2019-07-04 16:16 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120d0c8ca8a1297a1b25def5a25e7b41b2dd4bdc.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-media@vger.kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).