From: Hans Verkuil <hverkuil@xs4all.nl>
To: Greg KH <gregkh@linuxfoundation.org>,
Rohit Athavale <rohit.athavale@xilinx.com>
Cc: devel@driverdev.osuosl.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler
Date: Fri, 9 Mar 2018 12:57:49 +0100 [thread overview]
Message-ID: <1315ef81-15f1-5bc9-eff9-aaa12e70738a@xs4all.nl> (raw)
In-Reply-To: <20180222134658.GB19182@kroah.com>
On 22/02/18 14:46, Greg KH wrote:
> On Wed, Feb 21, 2018 at 02:43:14PM -0800, Rohit Athavale wrote:
>> This commit adds driver support for the pre-release Xilinx M2M Video
>> Scaler IP. There are three parts to this driver :
>>
>> - The Hardware/IP layer that reads and writes register of the IP
>> contained in the scaler_hw_xm2m.c
>> - The set of ioctls that applications would need to know contained
>> in ioctl_xm2mvsc.h
>> - The char driver that consumes the IP layer in xm2m_vscale.c
>>
>> Signed-off-by: Rohit Athavale <rohit.athavale@xilinx.com>
>> ---
>
> I need an ack from the linux-media maintainers before I can consider
> this for staging, as this really looks like an "odd" video driver...
This should definitely use the V4L2 API. I guess it could be added
to staging/media with a big fat TODO that this should be converted to
the V4L2 mem2mem framework.
But it makes no sense to re-invent the V4L2 streaming API :-)
drivers/media/platform/mx2_emmaprp.c does something similar to this.
It's a little bit outdated (not using the latest m2m helper functions)
but it is a good starting point.
So for this series:
Nacked-by: Hans Verkuil <hans.verkuil@cisco.com>
If this was added to drivers/staging/media instead and with an updated
TODO, then we can accept it, but we need to see some real effort afterwards
to switch this to the right API. Otherwise it will be removed again
after a few kernel cycles.
Regards,
Hans
next prev parent reply other threads:[~2018-03-09 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 22:43 [PATCH v2 0/3] Initial driver support for Xilinx M2M Video Scaler Rohit Athavale
2018-02-21 22:43 ` [PATCH v2 1/3] staging: xm2mvscale: Driver " Rohit Athavale
2018-02-22 13:46 ` Greg KH
2018-03-09 11:57 ` Hans Verkuil [this message]
2018-03-20 0:46 ` Rohit Athavale
2018-03-20 1:41 ` Nicolas Dufresne
2018-03-20 7:27 ` Hans Verkuil
2018-02-21 22:43 ` [PATCH v2 2/3] staging: xm2mvscale: Add TODO for the driver Rohit Athavale
2018-02-21 22:43 ` [PATCH v2 3/3] Documentation: devicetree: bindings: Add DT binding doc for xm2mvsc driver Rohit Athavale
2018-02-23 0:42 ` [PATCH v2 0/3] Initial driver support for Xilinx M2M Video Scaler Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315ef81-15f1-5bc9-eff9-aaa12e70738a@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=rohit.athavale@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).