linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Thierry Reding <thierry.reding@gmail.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
	linux-media@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194
Date: Tue, 11 Dec 2018 10:26:14 +0100	[thread overview]
Message-ID: <13d8fdb8-fc0e-9ad5-6405-110dd37ca5d5@xs4all.nl> (raw)
In-Reply-To: <20181210160038.16122-1-thierry.reding@gmail.com>

On 12/10/18 5:00 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The CEC controller found on Tegra186 and Tegra194 is the same as on
> earlier generations.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/drivers/media/platform/tegra-cec/tegra_cec.c
> index aba488cd0e64..8a1e10d008d0 100644
> --- a/drivers/media/platform/tegra-cec/tegra_cec.c
> +++ b/drivers/media/platform/tegra-cec/tegra_cec.c
> @@ -472,6 +472,8 @@ static const struct of_device_id tegra_cec_of_match[] = {
>  	{ .compatible = "nvidia,tegra114-cec", },
>  	{ .compatible = "nvidia,tegra124-cec", },
>  	{ .compatible = "nvidia,tegra210-cec", },
> +	{ .compatible = "nvidia,tegra186-cec", },
> +	{ .compatible = "nvidia,tegra194-cec", },
>  	{},
>  };
>  
> 

Applying: media: tegra-cec: Support Tegra186 and Tegra194
WARNING: DT compatible string "nvidia,tegra186-cec" appears un-documented -- check ./Documentation/devicetree/bindings/
#9: FILE: drivers/media/platform/tegra-cec/tegra_cec.c:475:
+       { .compatible = "nvidia,tegra186-cec", },

WARNING: DT compatible string "nvidia,tegra194-cec" appears un-documented -- check ./Documentation/devicetree/bindings/
#10: FILE: drivers/media/platform/tegra-cec/tegra_cec.c:476:
+       { .compatible = "nvidia,tegra194-cec", },

I need an additional patch adding the new bindings to
Documentation/devicetree/bindings/media/tegra-cec.txt.

Regards,

	Hans

  parent reply	other threads:[~2018-12-11  9:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 16:00 [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194 Thierry Reding
2018-12-10 16:00 ` [PATCH 2/2] media: tegra-cec: Export OF device ID match table Thierry Reding
2018-12-10 17:07 ` [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194 Hans Verkuil
2018-12-10 20:59   ` Thierry Reding
2018-12-11  9:19     ` Hans Verkuil
2018-12-11  9:38       ` Thierry Reding
2018-12-11  9:39         ` Hans Verkuil
2018-12-11  9:40         ` Hans Verkuil
2018-12-11 10:00           ` Thierry Reding
2018-12-11  9:26 ` Hans Verkuil [this message]
2018-12-11  9:39   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13d8fdb8-fc0e-9ad5-6405-110dd37ca5d5@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=hans.verkuil@cisco.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).