linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dinghao.liu@zju.edu.cn
To: "Sakari Ailus" <sakari.ailus@linux.intel.com>
Cc: kjlu@umn.edu, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] media: smiapp: Fix runtime PM imbalance on error
Date: Mon, 25 May 2020 16:14:17 +0800 (GMT+08:00)	[thread overview]
Message-ID: <142e32cb.c76d2.1724ae58dd9.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20200525080902.GC7618@paasikivi.fi.intel.com>

> Hi Dinghao,
> 
> Thanks for the patch.
> 
> On Fri, May 22, 2020 at 05:03:13PM +0800, Dinghao Liu wrote:
> > When v4l2_async_register_subdev_sensor_common() returns
> > an error code, a pairing runtime PM usage counter
> > decrement is needed to keep the counter balanced.
> > 
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> > ---
> >  drivers/media/i2c/smiapp/smiapp-core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
> > index 5e4f6a2ef78e..43ba63c48a87 100644
> > --- a/drivers/media/i2c/smiapp/smiapp-core.c
> > +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> > @@ -3103,6 +3103,7 @@ static int smiapp_probe(struct i2c_client *client)
> >  	return 0;
> >  
> >  out_disable_runtime_pm:
> > +	pm_runtime_put_autosuspend(&client->dev);
> 
> Can you use pm_runtime_put_noidle(), as the device musn't be powered off
> here yet?
> 
> >  	pm_runtime_disable(&client->dev);
> >  
> >  out_media_entity_cleanup:
> 
> -- 
> Regards,
> 
> Sakari Ailus

OK. I will fix this in the next version of patch.

Regards,
Dinghao

      reply	other threads:[~2020-05-25  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  9:03 [PATCH] media: smiapp: Fix runtime PM imbalance on error Dinghao Liu
2020-05-25  8:09 ` Sakari Ailus
2020-05-25  8:14   ` dinghao.liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=142e32cb.c76d2.1724ae58dd9.Coremail.dinghao.liu@zju.edu.cn \
    --to=dinghao.liu@zju.edu.cn \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).