Re: [PATCH 5/5] [media] tc358743: allow event subscription

[Philipp Zabel <p.zabel@pengutronix.de>]

Am Montag, den 13.07.2015, 13:07 +0200 schrieb Hans Verkuil:
> On 07/10/2015 03:11 PM, Philipp Zabel wrote:
> > This is useful to subscribe to HDMI hotplug events via the
> > V4L2_CID_DV_RX_POWER_PRESENT control.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  drivers/media/i2c/tc358743.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> > index 4a889d4..91fffa8 100644
> > --- a/drivers/media/i2c/tc358743.c
> > +++ b/drivers/media/i2c/tc358743.c
> > @@ -40,6 +40,7 @@
> >  #include <media/v4l2-dv-timings.h>
> >  #include <media/v4l2-device.h>
> >  #include <media/v4l2-ctrls.h>
> > +#include <media/v4l2-event.h>
> >  #include <media/v4l2-of.h>
> >  #include <media/tc358743.h>
> >  
> > @@ -1604,6 +1605,8 @@ static const struct v4l2_subdev_core_ops tc358743_core_ops = {
> >  	.s_register = tc358743_s_register,
> >  #endif
> >  	.interrupt_service_routine = tc358743_isr,
> > +	.subscribe_event = v4l2_ctrl_subdev_subscribe_event,
> 
> Ah, they are set here.
> 
> But note that v4l2_ctrl_subdev_subscribe_event is not enough, since this driver
> also issues the V4L2_EVENT_SOURCE_CHANGE event.
> 
> See this patch on how to do that:
> 
> http://git.linuxtv.org/cgit.cgi/hverkuil/media_tree.git/commit/?h=for-v4.3a&id=85c9b0b83795dac3d27043619a727af5c7313fe7
> 
> Note: requires the new v4l2_subdev_notify_event function that's not yet
> merged (just posted the pull request for that).

Ok, I think I'll split this up and send patch 5 separately, then.

regards
Philipp