From: Sean Wang <sean.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <mchehab@osg.samsung.com>, <hdegoede@redhat.com>,
<hkallweit1@gmail.com>, <mark.rutland@arm.com>,
<matthias.bgg@gmail.com>, <andi.shyti@samsung.com>,
<hverkuil@xs4all.nl>, <sean@mess.org>,
<ivo.g.dimitrov.75@gmail.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <keyhaede@gmail.com>
Subject: Re: [PATCH 1/2] Documentation: devicetree: Add document bindings for mtk-cir
Date: Tue, 10 Jan 2017 10:35:54 +0800 [thread overview]
Message-ID: <1484015754.4057.4.camel@mtkswgap22> (raw)
In-Reply-To: <20170109183214.xonv52sn3fo4exqp@rob-hp-laptop>
Hi Rob,
thanks for your effort for reviewing. I added comments inline.
On Mon, 2017-01-09 at 12:32 -0600, Rob Herring wrote:
> On Fri, Jan 06, 2017 at 12:06:23AM +0800, sean.wang@mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> >
> > This patch adds documentation for devicetree bindings for
> > Mediatek IR controller.
> >
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > ---
> > .../devicetree/bindings/media/mtk-cir.txt | 23 ++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> > create mode 100644 linux-4.8.rc1_p0/Documentation/devicetree/bindings/media/mtk-cir.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/Documentation/devicetree/bindings/media/mtk-cir.txt
> > new file mode 100644
> > index 0000000..bbedd71
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/mtk-cir.txt
> > @@ -0,0 +1,23 @@
> > +Device-Tree bindings for Mediatek IR controller found in Mediatek SoC family
> > +
> > +Required properties:
> > +- compatible : "mediatek,mt7623-ir"
> > +- clocks : list of clock specifiers, corresponding to
> > + entries in clock-names property;
> > +- clock-names : should contain "clk" entries;
> > +- interrupts : should contain IR IRQ number;
> > +- reg : should contain IO map address for IR.
> > +
> > +Optional properties:
> > +- linux,rc-map-name : Remote control map name.
>
> Would 'label' be appropriate here instead? If not, this needs to be
> documented in a common location and explained better.
>
I checked with how the way applied in other IR drivers is and found that
most IR driver also use the same label to identify the scan/key table
they prefer to use such as gpio-ir-recv, ir-hix5hd2, meson-ir and
sunxi-cir or use hard coding inside the driver. So I thought it should
be appropriate here currently.
> > +
> > +Example:
> > +
> > +cir: cir@0x10013000 {
>
> Drop the '0x'.
>
okay, I will.
> > + compatible = "mediatek,mt7623-ir";
> > + reg = <0 0x10013000 0 0x1000>;
> > + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> > + clocks = <&infracfg CLK_INFRA_IRRX>;
> > + clock-names = "clk";
> > + linux,rc-map-name = "rc-rc6-mce";
> > +};
> > --
> > 1.9.1
> >
next prev parent reply other threads:[~2017-01-10 2:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 16:06 [PATCH 0/2] media: rc: add support for IR receiver on MT7623 SoC sean.wang
2017-01-05 16:06 ` [PATCH 1/2] Documentation: devicetree: Add document bindings for mtk-cir sean.wang
2017-01-09 18:32 ` Rob Herring
2017-01-10 2:35 ` Sean Wang [this message]
2017-01-11 21:27 ` Rob Herring
2017-01-05 16:06 ` [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC sean.wang
2017-01-05 17:12 ` Sean Young
2017-01-06 7:31 ` Sean Wang
2017-01-08 21:16 ` Sean Young
2017-01-09 3:13 ` Sean Wang
2017-01-09 12:39 ` Sean Young
2017-01-06 3:43 ` Andi Shyti
2017-01-06 7:41 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484015754.4057.4.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=keyhaede@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=robh@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).