From: Brad Love <brad@nextdimension.cc>
To: linux-media@vger.kernel.org
Cc: Brad Love <brad@nextdimension.cc>
Subject: [PATCH 1/8] lgdt3306a: remove symbol count mismatch fix
Date: Tue, 6 Mar 2018 13:14:55 -0600 [thread overview]
Message-ID: <1520363702-25536-2-git-send-email-brad@nextdimension.cc> (raw)
In-Reply-To: <1520363702-25536-1-git-send-email-brad@nextdimension.cc>
This symbol mismatch is handled by NULL'ing out the release
callback if the driver is loaded as an i2c device.
This patch reverts:
- 94448e21cf08b10f7dc7acdaca387594370396b0
- 835d66173a38538c072a7c393d02360dcfac8582
The symbol count mismatch is handled by:
- 5b3a8e906973540b61dbf402c6b6f8d64d4ae119
Signed-off-by: Brad Love <brad@nextdimension.cc>
---
drivers/media/dvb-frontends/lgdt3306a.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
index 5b19033..7eb4e14 100644
--- a/drivers/media/dvb-frontends/lgdt3306a.c
+++ b/drivers/media/dvb-frontends/lgdt3306a.c
@@ -1814,13 +1814,7 @@ static void lgdt3306a_release(struct dvb_frontend *fe)
struct lgdt3306a_state *state = fe->demodulator_priv;
dbg_info("\n");
-
- /*
- * If state->muxc is not NULL, then we are an i2c device
- * and lgdt3306a_remove will clean up state
- */
- if (!state->muxc)
- kfree(state);
+ kfree(state);
}
static const struct dvb_frontend_ops lgdt3306a_ops;
@@ -2221,7 +2215,7 @@ static int lgdt3306a_probe(struct i2c_client *client,
sizeof(struct lgdt3306a_config));
config->i2c_addr = client->addr;
- fe = dvb_attach(lgdt3306a_attach, config, client->adapter);
+ fe = lgdt3306a_attach(config, client->adapter);
if (fe == NULL) {
ret = -ENODEV;
goto err_fe;
--
2.7.4
next prev parent reply other threads:[~2018-03-06 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 19:14 [PATCH 0/8] FIXME: Assorted of missed bits from merge Brad Love
2018-03-06 19:14 ` Brad Love [this message]
2018-03-06 19:14 ` [PATCH 2/8] em28xx: Change hex to lower case Brad Love
2018-03-06 19:14 ` [PATCH 3/8] cx231xx: Use frontend i2c adapter with tuner Brad Love
2018-03-06 19:14 ` [PATCH 4/8] cx23885: Add tuner type and analog inputs to 1265 Brad Love
2018-03-06 19:14 ` [PATCH 5/8] cx231xx: Set mfe_shared if second frontend found Brad Love
2018-03-06 19:15 ` [PATCH 6/8] cx231xx: Use constant instead of hard code for max Brad Love
2018-03-06 19:15 ` [PATCH 7/8] cx231xx: Add second i2c demod to Hauppauge 975 Brad Love
2018-03-06 19:15 ` [PATCH 8/8] cx23885: Fix gpio on Hauppauge QuadHD PCIe cards Brad Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520363702-25536-2-git-send-email-brad@nextdimension.cc \
--to=brad@nextdimension.cc \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).