From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E38AC169C4 for ; Mon, 11 Feb 2019 10:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 516B720821 for ; Mon, 11 Feb 2019 10:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726105AbfBKK31 (ORCPT ); Mon, 11 Feb 2019 05:29:27 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:55569 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbfBKK31 (ORCPT ); Mon, 11 Feb 2019 05:29:27 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gt8q5-0002dM-AT; Mon, 11 Feb 2019 11:29:25 +0100 Message-ID: <1549880963.7687.8.camel@pengutronix.de> Subject: Re: [PATCH v2 4/4] media: imx-pxp: Start using the format VUYA32 instead of YUV32 (v2) From: Philipp Zabel To: Vivek Kasireddy , linux-media@vger.kernel.org Date: Mon, 11 Feb 2019 11:29:23 +0100 In-Reply-To: <20190209013818.979-1-vivek.kasireddy@intel.com> References: <1549621864.3305.5.camel@pengutronix.de> <20190209013818.979-1-vivek.kasireddy@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 2019-02-08 at 17:38 -0800, Vivek Kasireddy wrote: > Buffers generated with YUV32 format seems to be incorrect, hence use > VUYA32 instead. > > Changes from v1: > Add both formats VUYA32 and VUYX32 but associate only VUYX32 to the > output queue as the alpha channel of buffers is ignored on this queue. > > Cc: Philipp Zabel > Signed-off-by: Vivek Kasireddy Thank you, Reviewed-by: Philipp Zabel regards Philipp > --- > drivers/media/platform/imx-pxp.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c > index f087dc4fc729..0bcfc5aa8f3d 100644 > --- a/drivers/media/platform/imx-pxp.c > +++ b/drivers/media/platform/imx-pxp.c > @@ -90,7 +90,11 @@ static struct pxp_fmt formats[] = { > .depth = 16, > .types = MEM2MEM_CAPTURE | MEM2MEM_OUTPUT, > }, { > - .fourcc = V4L2_PIX_FMT_YUV32, > + .fourcc = V4L2_PIX_FMT_VUYA32, > + .depth = 32, > + .types = MEM2MEM_CAPTURE, > + }, { > + .fourcc = V4L2_PIX_FMT_VUYX32, > .depth = 32, > .types = MEM2MEM_CAPTURE | MEM2MEM_OUTPUT, > }, { > @@ -236,7 +240,7 @@ static u32 pxp_v4l2_pix_fmt_to_ps_format(u32 v4l2_pix_fmt) > case V4L2_PIX_FMT_RGB555: return BV_PXP_PS_CTRL_FORMAT__RGB555; > case V4L2_PIX_FMT_RGB444: return BV_PXP_PS_CTRL_FORMAT__RGB444; > case V4L2_PIX_FMT_RGB565: return BV_PXP_PS_CTRL_FORMAT__RGB565; > - case V4L2_PIX_FMT_YUV32: return BV_PXP_PS_CTRL_FORMAT__YUV1P444; > + case V4L2_PIX_FMT_VUYX32: return BV_PXP_PS_CTRL_FORMAT__YUV1P444; > case V4L2_PIX_FMT_UYVY: return BV_PXP_PS_CTRL_FORMAT__UYVY1P422; > case V4L2_PIX_FMT_YUYV: return BM_PXP_PS_CTRL_WB_SWAP | > BV_PXP_PS_CTRL_FORMAT__UYVY1P422; > @@ -265,7 +269,8 @@ static u32 pxp_v4l2_pix_fmt_to_out_format(u32 v4l2_pix_fmt) > case V4L2_PIX_FMT_RGB555: return BV_PXP_OUT_CTRL_FORMAT__RGB555; > case V4L2_PIX_FMT_RGB444: return BV_PXP_OUT_CTRL_FORMAT__RGB444; > case V4L2_PIX_FMT_RGB565: return BV_PXP_OUT_CTRL_FORMAT__RGB565; > - case V4L2_PIX_FMT_YUV32: return BV_PXP_OUT_CTRL_FORMAT__YUV1P444; > + case V4L2_PIX_FMT_VUYA32: > + case V4L2_PIX_FMT_VUYX32: return BV_PXP_OUT_CTRL_FORMAT__YUV1P444; > case V4L2_PIX_FMT_UYVY: return BV_PXP_OUT_CTRL_FORMAT__UYVY1P422; > case V4L2_PIX_FMT_VYUY: return BV_PXP_OUT_CTRL_FORMAT__VYUY1P422; > case V4L2_PIX_FMT_GREY: return BV_PXP_OUT_CTRL_FORMAT__Y8; > @@ -281,7 +286,8 @@ static u32 pxp_v4l2_pix_fmt_to_out_format(u32 v4l2_pix_fmt) > static bool pxp_v4l2_pix_fmt_is_yuv(u32 v4l2_pix_fmt) > { > switch (v4l2_pix_fmt) { > - case V4L2_PIX_FMT_YUV32: > + case V4L2_PIX_FMT_VUYA32: > + case V4L2_PIX_FMT_VUYX32: > case V4L2_PIX_FMT_UYVY: > case V4L2_PIX_FMT_YUYV: > case V4L2_PIX_FMT_VYUY: