From: Stu Hsieh <stu.hsieh@mediatek.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>, CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Stu Hsieh <stu.hsieh@mediatek.com>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>
Subject: [PATCH v3 11/13] [media] mtk-mipicsi: add function to get the format
Date: Tue, 14 May 2019 14:13:48 +0800 [thread overview]
Message-ID: <1557814430-9675-12-git-send-email-stu.hsieh@mediatek.com> (raw)
In-Reply-To: <1557814430-9675-1-git-send-email-stu.hsieh@mediatek.com>
This patch add function to get the format
This function can get the subdev format and host format.
Calculate the number of format which intersection of subdev and host.
Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
---
.../media/platform/mtk-mipicsi/mtk_mipicsi.c | 151 ++++++++++++++++++
1 file changed, 151 insertions(+)
diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
index cf46fcd01a19..1b885de6d990 100644
--- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
+++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c
@@ -56,6 +56,7 @@
#define MIPICSI_CLK (MIPICSI_COMMON_CLK + MTK_CAMDMA_MAX_NUM)
#define MAX_DES_LINK 4U
#define SUBDEV_LINK_REG 0x49
+#define MTK_DATAWIDTH_8 (0x01U << 7U)
#define MAX_SUPPORT_WIDTH 4096U
#define MAX_SUPPORT_HEIGHT 4096U
#define MAX_BUFFER_NUM 32U
@@ -134,6 +135,7 @@ struct mtk_mipicsi_dev {
struct regmap *seninf_top;
void __iomem *seninf_mux[MTK_CAMDMA_MAX_NUM];
void __iomem *camsv[MTK_CAMDMA_MAX_NUM];
+ u16 width_flags; /* max 12 bits */
struct list_head fb_list;
spinlock_t lock;
spinlock_t queue_lock;
@@ -152,6 +154,50 @@ struct mtk_mipicsi_dev {
u32 bytesperline;
};
+static const struct soc_mbus_lookup mtk_mipicsi_formats[] = {
+{
+ .code = MEDIA_BUS_FMT_YUYV8_2X8,
+ .fmt = {
+ .fourcc = V4L2_PIX_FMT_YUYV,
+ .name = "YUYV",
+ .bits_per_sample = 8,
+ .packing = SOC_MBUS_PACKING_2X8_PADHI,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+}, {
+ .code = MEDIA_BUS_FMT_YVYU8_2X8,
+ .fmt = {
+ .fourcc = V4L2_PIX_FMT_YVYU,
+ .name = "YVYU",
+ .bits_per_sample = 8,
+ .packing = SOC_MBUS_PACKING_2X8_PADHI,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+}, {
+ .code = MEDIA_BUS_FMT_UYVY8_2X8,
+ .fmt = {
+ .fourcc = V4L2_PIX_FMT_UYVY,
+ .name = "UYVY",
+ .bits_per_sample = 8,
+ .packing = SOC_MBUS_PACKING_2X8_PADHI,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+}, {
+ .code = MEDIA_BUS_FMT_VYUY8_2X8,
+ .fmt = {
+ .fourcc = V4L2_PIX_FMT_VYUY,
+ .name = "VYUY",
+ .bits_per_sample = 8,
+ .packing = SOC_MBUS_PACKING_2X8_PADHI,
+ .order = SOC_MBUS_ORDER_LE,
+ .layout = SOC_MBUS_LAYOUT_PACKED,
+ },
+},
+};
+
#define MTK_MIPICSI_BUS_PARAM (V4L2_MBUS_MASTER | \
V4L2_MBUS_HSYNC_ACTIVE_HIGH | \
V4L2_MBUS_HSYNC_ACTIVE_LOW | \
@@ -196,6 +242,43 @@ static void mtk_mipicsi_ana_clk_enable(void __iomem *base, bool enable)
}
}
+static int mtk_mipicsi_try_bus_param(struct soc_camera_device *icd,
+ unsigned char buswidth)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ struct soc_camera_host *ici = to_soc_camera_host(icd->parent);
+ struct mtk_mipicsi_dev *mipicsi = ici->priv;
+ struct v4l2_mbus_config cfg = {.type = V4L2_MBUS_CSI2_DPHY,};
+ unsigned long common_flags = 0;
+ int ret = 0;
+
+ ret = v4l2_subdev_call(sd, video, g_mbus_config, &cfg);
+ if (ret == 0) {
+ common_flags = soc_mbus_config_compatible(&cfg,
+ MTK_MIPICSI_BUS_PARAM);
+ if (common_flags == 0U) {
+ dev_warn(icd->parent, "Flags incompatible: camera 0x%x\n",
+ cfg.flags);
+ return -EINVAL;
+ }
+ } else {
+ if (ret != -ENOIOCTLCMD)
+ return ret;
+ }
+
+ if ((((u16)1U << (buswidth - 1U)) & mipicsi->width_flags) != 0U)
+ return 0;
+
+ return -EINVAL;
+}
+
+static bool mtk_mipicsi_packing_supported(const struct soc_mbus_pixelfmt *fmt)
+{
+ return fmt->packing == SOC_MBUS_PACKING_NONE ||
+ (fmt->bits_per_sample == 8U &&
+ fmt->packing == SOC_MBUS_PACKING_2X8_PADHI);
+}
+
static int get_subdev_register(const struct soc_camera_device *icd,
struct v4l2_dbg_register *reg)
{
@@ -322,6 +405,72 @@ static void mtk_mipicsi_remove_device(struct soc_camera_device *icd)
(void)pm_runtime_put_sync(icd->parent);
}
+static int mtk_mipicsi_get_formats(struct soc_camera_device *icd,
+ unsigned int idx, struct soc_camera_format_xlate *xlate)
+{
+ struct v4l2_subdev *sd = soc_camera_to_subdev(icd);
+ int formats = 0, ret, i;
+ int n = ARRAY_SIZE(mtk_mipicsi_formats);
+
+ struct v4l2_subdev_mbus_code_enum mbus_code = {
+ .which = V4L2_SUBDEV_FORMAT_ACTIVE,
+ .index = idx,
+ };
+ /* subdev format */
+ const struct soc_mbus_pixelfmt *fmt;
+
+ ret = v4l2_subdev_call(sd, pad, enum_mbus_code, NULL, &mbus_code);
+ if (ret < 0)
+ /* No more formats */
+ return 0;
+
+ /* get subdev support format */
+ fmt = soc_mbus_get_fmtdesc(mbus_code.code);
+ if (fmt == NULL) {
+ dev_err(icd->parent, "Invalid format code #%u: %d",
+ idx, mbus_code.code);
+ return 0;
+ }
+
+ /* This also checks support for the requested bits-per-sample */
+ ret = mtk_mipicsi_try_bus_param(icd, fmt->bits_per_sample);
+ if (ret < 0) {
+ dev_err(icd->parent, "Fail to try the bus parameters.\n");
+ return 0;
+ }
+
+ switch (mbus_code.code) {
+ case MEDIA_BUS_FMT_UYVY8_2X8:
+ case MEDIA_BUS_FMT_VYUY8_2X8:
+ case MEDIA_BUS_FMT_YUYV8_2X8:
+ case MEDIA_BUS_FMT_YVYU8_2X8:
+ dev_dbg(icd->parent, "Providing format %s using code %d\n",
+ fmt->name, mbus_code.code);
+ break;
+ default:
+ if (!mtk_mipicsi_packing_supported(fmt))
+ return 0;
+ if (xlate != NULL)
+ dev_dbg(icd->parent,
+ "Providing format %s in pass-through mode\n",
+ fmt->name);
+ break;
+ }
+
+ /* get camera host and subdev format intersection */
+ for (i = 0; i < n; ++i)
+ if (mtk_mipicsi_formats[i].fmt.fourcc == fmt->fourcc) {
+ ++formats;
+ if (xlate != NULL) {
+ xlate->host_fmt = &mtk_mipicsi_formats[i].fmt;
+ xlate->code = mbus_code.code;
+ xlate++;
+ }
+ }
+
+ return formats;
+}
+
static bool is_supported(const u32 pixformat)
{
switch (pixformat) {
@@ -711,6 +860,7 @@ static struct soc_camera_host_ops mtk_soc_camera_host_ops = {
.owner = THIS_MODULE,
.add = mtk_mipicsi_add_device,
.remove = mtk_mipicsi_remove_device,
+ .get_formats = mtk_mipicsi_get_formats,
.set_fmt = mtk_mipicsi_set_fmt,
.try_fmt = mtk_mipicsi_try_fmt,
.init_videobuf2 = mtk_mipicsi_init_videobuf2,
@@ -1297,6 +1447,7 @@ static int mtk_mipicsi_probe(struct platform_device *pdev)
mipicsi->soc_host.priv = mipicsi;
mipicsi->soc_host.v4l2_dev.dev = &pdev->dev;
mipicsi->soc_host.nr = mipicsi->id;
+ mipicsi->width_flags = MTK_DATAWIDTH_8;
mipicsi->streamon = false;
ret = soc_camera_host_register(&mipicsi->soc_host);
--
2.18.0
next prev parent reply other threads:[~2019-05-14 6:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 6:13 [PATCH v3 00/13] Add mediatek mipicsi driver for Mediatek SOC MT2712 Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 01/13] dt-bindings: media: Add binding for MT2712 MIPI-CSI2 Stu Hsieh
2019-05-14 19:28 ` Rob Herring
2019-05-14 6:13 ` [PATCH v3 02/13] [media] mtk-mipicsi: add mediatek mipicsi driver for mt2712 Stu Hsieh
2019-05-17 7:37 ` CK Hu
2019-05-14 6:13 ` [PATCH v3 03/13] [media] mtk-mipicsi: register the soc_camera host Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 04/13] [media] mtk-mipicsi: add the check for non-supported color format Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 05/13] [media] mtk-mipicsi: get the w/h/bytepwerline for mtk_mipicsi Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 06/13] [media] mtk-mipicsi: add function to support SerDes for link number Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 07/13] [media] mtk-mipicsi: enable/disable ana clk Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 08/13] [media] mtk-mipicsi: enable/disable cmos for mt2712 Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 09/13] [media] mtk-mipicsi: add ISR for writing the data to buffer Stu Hsieh
2019-05-17 9:05 ` CK Hu
2019-05-14 6:13 ` [PATCH v3 10/13] [media] mtk-mipicsi: set the output address in HW reg Stu Hsieh
2019-05-14 6:13 ` Stu Hsieh [this message]
2019-05-14 6:13 ` [PATCH v3 12/13] [media] mtk-mipicsi: add debug message for mipicsi driver Stu Hsieh
2019-05-14 6:13 ` [PATCH v3 13/13] [media] mtk-mipicsi: add debugfs " Stu Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557814430-9675-12-git-send-email-stu.hsieh@mediatek.com \
--to=stu.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).