From: Paul Cercueil <paul@crapouillou.net>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Hans Verkuil <hansverk@cisco.com>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
od@zcrc.me
Subject: Re: [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel
Date: Wed, 05 Jun 2019 23:59:58 +0200 [thread overview]
Message-ID: <1559771998.1972.0@crapouillou.net> (raw)
In-Reply-To: <20190605112645.5b357630@coco.lan>
Le mer. 5 juin 2019 à 16:26, Mauro Carvalho Chehab
<mchehab+samsung@kernel.org> a écrit :
> Em Mon, 3 Jun 2019 17:35:10 +0200
> Paul Cercueil <paul@crapouillou.net> escreveu:
>
>> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB
>> components
>> are transferred sequentially on a 8-bit bus.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>>
>> Notes:
>> v2: New patch
>>
>> v3: No change
>>
>> v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care
>> about
>> endianness
>
> Same comment as on version 3:
>
> You should also patch the documentation text at:
>
> Documentation/media/uapi/v4l/subdev-formats.rst
>
> In order to describe the new format that will be included.
Ouch. Sorry. Will do.
-Paul
>
>>
>> include/uapi/linux/media-bus-format.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/media-bus-format.h
>> b/include/uapi/linux/media-bus-format.h
>> index 2a6b253cfb05..16c1fa2d89a4 100644
>> --- a/include/uapi/linux/media-bus-format.h
>> +++ b/include/uapi/linux/media-bus-format.h
>> @@ -34,7 +34,7 @@
>>
>> #define MEDIA_BUS_FMT_FIXED 0x0001
>>
>> -/* RGB - next is 0x101c */
>> +/* RGB - next is 0x101d */
>> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
>> @@ -55,6 +55,7 @@
>> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
>> +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c
>> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
>> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
>> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
>
>
>
> Thanks,
> Mauro
next prev parent reply other threads:[~2019-06-05 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 15:35 [PATCH v4 1/3] dt-bindings: display: Add GiantPlus GPM940B0 panel documentation Paul Cercueil
2019-06-03 15:35 ` [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Paul Cercueil
2019-06-05 14:26 ` Mauro Carvalho Chehab
2019-06-05 21:59 ` Paul Cercueil [this message]
2019-06-03 15:35 ` [PATCH v4 3/3] drm/panel: simple: Add GiantPlus GPM940B0 panel support Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559771998.1972.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansverk@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=od@zcrc.me \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).