From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76CCC43218 for ; Tue, 11 Jun 2019 08:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D78820657 for ; Tue, 11 Jun 2019 08:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403992AbfFKIwP (ORCPT ); Tue, 11 Jun 2019 04:52:15 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:42261 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403860AbfFKIwO (ORCPT ); Tue, 11 Jun 2019 04:52:14 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hacVl-0000Hr-C9; Tue, 11 Jun 2019 10:52:09 +0200 Message-ID: <1560243127.13886.3.camel@pengutronix.de> Subject: Re: [PATCH v7 2/4] media: videodev2: add V4L2_FMT_FLAG_FIXED_RESOLUTION From: Philipp Zabel To: Hans Verkuil , Maxime Jourdan , Mauro Carvalho Chehab , Hans Verkuil Cc: Kevin Hilman , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Date: Tue, 11 Jun 2019 10:52:07 +0200 In-Reply-To: <9731b2db-efd4-87d0-c48d-87adec433747@xs4all.nl> References: <20190531093126.26956-1-mjourdan@baylibre.com> <20190531093126.26956-3-mjourdan@baylibre.com> <9731b2db-efd4-87d0-c48d-87adec433747@xs4all.nl> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 2019-06-05 at 15:39 +0200, Hans Verkuil wrote: > Hi Maxime, > > I am wondering if this flag shouldn't be inverted: you set > V4L2_FMT_FLAG_DYN_RESOLUTION if dynamic resolution is supported, > otherwise it isn't. > > Can all the existing mainlined codec drivers handle midstream > resolution changes? > > s5p-mfc, venus and mediatek can, but I see no SOURCE_CHANGE event in > the coda drivers, so I suspect that that can't handle this. > > Philipp, what is the status of the coda driver for dynamic resolution > changes? FTR, to my knowledge there is no dynamic resolution change support in the firmware, as there is no signal (interrupt nor picture run return value) to indicate that different headers were parsed. I am planning to add the initial source change event required by the current decoder API documentation, but I am afraid there will be no support for source changes due to mid-stream resolution changes due to firmware limitations. regards Philipp