From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D67C31E50 for ; Sat, 15 Jun 2019 15:01:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 787EB2133D for ; Sat, 15 Jun 2019 15:01:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mlxe0+lC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbfFOPBK (ORCPT ); Sat, 15 Jun 2019 11:01:10 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35792 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfFOPBK (ORCPT ); Sat, 15 Jun 2019 11:01:10 -0400 Received: by mail-pl1-f196.google.com with SMTP id p1so2251353plo.2 for ; Sat, 15 Jun 2019 08:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=d/LYfEaalp5LFqT9rkfYpwhznVcTdVjFdPH1FV2t1KU=; b=mlxe0+lC6cabtTmQeoZyhhBKKesqoZDy/LH67jIaW73jeMJZ1/bbmCtLepu5YpleEk hwyAX+1Ll6J4iyoj18nNx05VXbYGtu8E4KvXhBwcxrvv7GCA/Wbu9XkvdkcGDHwCYWlj 1/8+HyKYWJEgKAWzmsbf/a98MVgrgrIuwT/RjnAs+PEX7vj2fNEv9TeOX1YUOdaUmEeq gSjSPzwX3AtEKnXNmz9HdGmBor/XCmrgRAd6D5gZlD/0i47OTHDrkobUFkdmZ/xOigl5 dGc+aJmSIFZuHiFAHgDznRg6LhDfwXrZgwrOpY/k6kN/jd7czsEOn/4AzvDIgre2q7aY Ca8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d/LYfEaalp5LFqT9rkfYpwhznVcTdVjFdPH1FV2t1KU=; b=MFYkJ8rXWZ0YbTJJrmb2i1w98kuTsD8m/I51iT88VH43hhoOUppIExXQYDsW3IxX0G /RtHFD8GHDOA1t1aWDvFZoctet1FIgPBEkaS7sT6zbCPT+tPHCGCOPV6w/7K9WfTR0Uy XwiF/PvdzWeJyO/LMaAC5eIYQDwkrB4SboNjnbUHAQ3reOQ8uhom+hBqBqUZ4AqEyCui KtLiRFo3k8UV8X8EN2Dw3ycaCNRRh82iah2bUjTptak1qkFu+gGYOXskeE+DvKpdN8ST /i5iXcK2gOFUiWiCHAkCG+DNkBGYTYCG2f/C38Hv57nWqUp7Ur870w/r/tStgKP0ZkyA 3p1A== X-Gm-Message-State: APjAAAV1UjP3nGC6wTLvDq4pPEOFgC8HD8WqgwzJMBe38lecPcv3zzVM OS8QWDjxXo1TyUHiB4BEV+xY1mp2QOg= X-Google-Smtp-Source: APXvYqyPPnCZ8d9YmWIC4DEOfES3sehFVbLwy2rJbt94MtUCVjMMq5zZ3+tXP8p0CdxwRNnQOw4jYg== X-Received: by 2002:a17:902:2006:: with SMTP id n6mr41875637pla.232.1560610869668; Sat, 15 Jun 2019 08:01:09 -0700 (PDT) Received: from localhost.localdomain ([240f:34:212d:1:1b24:991b:df50:ea3f]) by smtp.gmail.com with ESMTPSA id m6sm7428633pgr.18.2019.06.15.08.01.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 15 Jun 2019 08:01:08 -0700 (PDT) From: Akinobu Mita To: linux-media@vger.kernel.org Cc: Akinobu Mita , Matt Ranostay , Sakari Ailus , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH] media: video-i2c: use V4L2_FRACT_COMPARE Date: Sun, 16 Jun 2019 00:00:57 +0900 Message-Id: <1560610857-20978-1-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Use V4L2_FRACT_COMPARE to check whether two v4l2_fract structs are equal. Cc: Matt Ranostay Cc: Sakari Ailus Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/video-i2c.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index abd3152..0781417 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -190,12 +190,8 @@ static int mlx90640_setup(struct video_i2c_data *data) unsigned int n, idx; for (n = 0; n < data->chip->num_frame_intervals - 1; n++) { - if (data->frame_interval.numerator - != data->chip->frame_intervals[n].numerator) - continue; - - if (data->frame_interval.denominator - == data->chip->frame_intervals[n].denominator) + if (V4L2_FRACT_COMPARE(data->frame_interval, ==, + data->chip->frame_intervals[n])) break; } -- 2.7.4