From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A717C3A59E for ; Wed, 21 Aug 2019 14:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D230D22D6D for ; Wed, 21 Aug 2019 14:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbfHUOzO convert rfc822-to-8bit (ORCPT ); Wed, 21 Aug 2019 10:55:14 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:53894 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727286AbfHUOzO (ORCPT ); Wed, 21 Aug 2019 10:55:14 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 18215646-1500050 for multiple; Wed, 21 Aug 2019 15:55:10 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: Chris Wilson User-Agent: alot/0.6 To: =?utf-8?q?Christian_K=C3=B6nig?= , daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, sumit.semwal@linaro.org References: <20190821123147.110736-1-christian.koenig@amd.com> <20190821123147.110736-6-christian.koenig@amd.com> In-Reply-To: <20190821123147.110736-6-christian.koenig@amd.com> Message-ID: <156639930822.1374.18129686805314896871@skylake-alporthouse-com> Subject: Re: [PATCH 05/10] dma-buf/resv: add dma_resv_prune_fences Date: Wed, 21 Aug 2019 15:55:08 +0100 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Quoting Christian König (2019-08-21 13:31:42) > Add a new dma_resv_prune_fences() function to improve memory management. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 37 ++++++++++++++++++++++ > drivers/gpu/drm/i915/gem/i915_gem_wait.c | 3 +- > drivers/gpu/drm/i915/i915_gem_batch_pool.c | 2 +- > drivers/gpu/drm/i915/i915_vma.c | 3 +- > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > include/linux/dma-resv.h | 1 + > 6 files changed, 42 insertions(+), 6 deletions(-) > > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c > index 42a8f3f11681..24adc32d36d4 100644 > --- a/drivers/dma-buf/dma-resv.c > +++ b/drivers/dma-buf/dma-resv.c > @@ -301,6 +301,43 @@ void dma_resv_add_excl_fence(struct dma_resv *obj, struct dma_fence *fence) > } > EXPORT_SYMBOL(dma_resv_add_excl_fence); > > +/** > + * dma_resv_prune_fences - prune signaled fences from the resv object > + * @obj: the reservation object to prune > + * > + * Prune all signaled fences from the reservation object. > + */ > +void dma_resv_prune_fences(struct dma_resv *obj) > +{ > + struct dma_resv_list *list; > + struct dma_fence *fence; > + unsigned int i; > + > + dma_resv_assert_held(obj); > + > + fence = dma_resv_get_excl(obj); > + if (dma_fence_is_signaled(fence)) { > + RCU_INIT_POINTER(obj->fence_excl, NULL); > + dma_fence_put(fence); > + } > + > + list = dma_resv_get_list(obj); > + if (!list) > + return; > + > + for (i = 0; i < list->shared_count; ++i) { > + fence = rcu_dereference_protected(list->shared[i], > + dma_resv_held(obj)); > + > + if (!dma_fence_is_signaled(fence)) > + continue; > + > + RCU_INIT_POINTER(list->shared[i], dma_fence_get_stub()); > + dma_fence_put(fence); Not worth reusing the compaction logic from add_shared_fence? -Chris