From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Louis Kuo <louis.kuo@mediatek.com>
Cc: <hans.verkuil@cisco.com>,
<laurent.pinchart+renesas@ideasonboard.com>, <tfiga@chromium.org>,
<keiichiw@chromium.org>, <matthias.bgg@gmail.com>,
<mchehab@kernel.org>, <devicetree@vger.kernel.org>,
<Sean.Cheng@mediatek.com>, <Rynn.Wu@mediatek.com>,
<srv_heupstream@mediatek.com>, <Jerry-ch.Chen@mediatek.com>,
<jungo.lin@mediatek.com>, <sj.huang@mediatek.com>,
<yuzhao@chromium.org>, <linux-mediatek@lists.infradead.org>,
<zwisler@chromium.org>, <christie.yu@mediatek.com>,
<frederic.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>
Subject: Re: [RFC PATCH V4 3/4] dt-bindings: mt8183: Add sensor interface dt-bindings
Date: Mon, 16 Sep 2019 13:33:22 +0800 [thread overview]
Message-ID: <1568612002.14078.1.camel@mtksdaap41> (raw)
In-Reply-To: <20190915065004.20257-4-louis.kuo@mediatek.com>
On Sun, 2019-09-15 at 14:50 +0800, Louis Kuo wrote:
> This patch adds the DT binding documentation for the sensor interface
> module in Mediatek SoCs.
>
> Signed-off-by: Louis Kuo <louis.kuo@mediatek.com>
> ---
> .../bindings/media/mediatek-seninf.txt | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-seninf.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-seninf.txt b/Documentation/devicetree/bindings/media/mediatek-seninf.txt
> new file mode 100644
> index 000000000000..bf2eb801cb47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-seninf.txt
> @@ -0,0 +1,30 @@
> +* Mediatek seninf MIPI-CSI2 host driver
> +
> +Seninf MIPI-CSI2 host driver is a HW camera interface controller. It support a widely adopted,
> +simple, high-speed protocol primarily intended for point-to-point image and video
> +transmission between cameras and host devices.
> +
> +Required properties:
> + - compatible: "mediatek,mt8183-seninf"
> + - reg: Must contain an entry for each entry in reg-names.
> + - reg-names: Must include the following entries:
> + "base_reg": seninf registers base
> + "rx_reg": Rx analog registers base
Everyone here is a reg. Adding _reg prefix for everyone looks redundant.
Same for clock-names.
> + - interrupts: interrupt number to the cpu.
> + - clocks : clock name from clock manager
> + - clock-names: must be CLK_CAM_SENINF and CLK_TOP_MUX_SENINF.
> + It is the clocks of seninf
> +
Joe.C
next prev parent reply other threads:[~2019-09-16 5:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 6:50 [RFC PATCH V4 0/4] media: support Mediatek sensor interface driver Louis Kuo
2019-09-15 6:50 ` [RFC PATCH V4 1/4] media: platform: mtk-isp: Add " Louis Kuo
2019-09-16 1:28 ` Yingjoe Chen
2019-09-18 8:11 ` Sakari Ailus
2019-09-15 6:50 ` [RFC PATCH V4 2/4] media: platform: Add Mediatek sensor interface driver KConfig Louis Kuo
2019-09-16 1:18 ` Yingjoe Chen
2019-09-18 8:16 ` Sakari Ailus
2019-09-15 6:50 ` [RFC PATCH V4 3/4] dt-bindings: mt8183: Add sensor interface dt-bindings Louis Kuo
2019-09-16 5:33 ` Yingjoe Chen [this message]
2019-09-18 8:29 ` Sakari Ailus
2019-09-15 6:50 ` [RFC PATCH V4 4/4] dts: arm64: mt8183: Add sensor interface nodes Louis Kuo
2019-09-16 5:36 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568612002.14078.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=Jerry-ch.Chen@mediatek.com \
--cc=Rynn.Wu@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frederic.chen@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=jungo.lin@mediatek.com \
--cc=keiichiw@chromium.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).