From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADECC49ED7 for ; Mon, 16 Sep 2019 05:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B75F120644 for ; Mon, 16 Sep 2019 05:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729128AbfIPFgT (ORCPT ); Mon, 16 Sep 2019 01:36:19 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:41092 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727664AbfIPFgS (ORCPT ); Mon, 16 Sep 2019 01:36:18 -0400 X-UUID: a6ce23b18d474d67927eebfc7ae363b1-20190916 X-UUID: a6ce23b18d474d67927eebfc7ae363b1-20190916 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1568301184; Mon, 16 Sep 2019 13:36:13 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 16 Sep 2019 13:36:11 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 16 Sep 2019 13:36:11 +0800 Message-ID: <1568612172.14078.3.camel@mtksdaap41> Subject: Re: [RFC PATCH V4 4/4] dts: arm64: mt8183: Add sensor interface nodes From: Yingjoe Chen To: Louis Kuo CC: , , , , , , , , , , , , , , , , , , , Date: Mon, 16 Sep 2019 13:36:12 +0800 In-Reply-To: <20190915065004.20257-5-louis.kuo@mediatek.com> References: <20190915065004.20257-1-louis.kuo@mediatek.com> <20190915065004.20257-5-louis.kuo@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Sun, 2019-09-15 at 14:50 +0800, Louis Kuo wrote: > Add nodes for Mediatek's sensor interface device. Sensor interface module > embedded in Mediatek SOCs, works as a HW camera interface controller > intended for image and data transmission between cameras and host devices. > > Signed-off-by: Louis Kuo > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 66aaa07f6cec..f1d081b99867 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -506,4 +506,18 @@ > #clock-cells = <1>; > }; > }; > + > + seninf: seninf@1a040000 { > + compatible = "mediatek,mt8183-seninf"; > + reg = <0 0x1a040000 0 0x8000>, > + <0 0x11C80000 0 0x6000>; Please use lower case for hex value. > + reg-names = "base_reg", "rx_reg"; > + interrupts = ; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_CAM>; > + clocks = <&camsys CLK_CAM_SENINF>, > + <&topckgen CLK_TOP_MUX_SENINF>; > + clock-names = "CLK_CAM_SENINF", "CLK_TOP_MUX_SENINF"; > + status = "disabled"; > + }; > + }; extra } ? Joe.C