From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9DCC2D0DB for ; Fri, 24 Jan 2020 10:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E7C8206F0 for ; Fri, 24 Jan 2020 10:21:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731249AbgAXKVD convert rfc822-to-8bit (ORCPT ); Fri, 24 Jan 2020 05:21:03 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:59758 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727215AbgAXKVD (ORCPT ); Fri, 24 Jan 2020 05:21:03 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19992557-1500050 for multiple; Fri, 24 Jan 2020 10:20:58 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Dan Carpenter , Sumit Semwal From: Chris Wilson In-Reply-To: <20200124101311.drryaegcdc7d4x7e@kili.mountain> Cc: Gustavo Padovan , Sean Paul , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kernel-janitors@vger.kernel.org References: <20200124101311.drryaegcdc7d4x7e@kili.mountain> Message-ID: <157986125623.2524.13979010293671565726@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH] dma-buf: fix locking in sync_print_obj() Date: Fri, 24 Jan 2020 10:20:56 +0000 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Quoting Dan Carpenter (2020-01-24 10:13:12) > This is always called with IRQs disabled and we don't actually want to > enable IRQs at the end. > > Fixes: a6aa8fca4d79 ("dma-buf/sw-sync: Reduce irqsave/irqrestore from known context") > Signed-off-by: Dan Carpenter > --- > drivers/dma-buf/sync_debug.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/sync_debug.c b/drivers/dma-buf/sync_debug.c > index 101394f16930..952331344b1c 100644 > --- a/drivers/dma-buf/sync_debug.c > +++ b/drivers/dma-buf/sync_debug.c > @@ -107,15 +107,16 @@ static void sync_print_fence(struct seq_file *s, > static void sync_print_obj(struct seq_file *s, struct sync_timeline *obj) > { > struct list_head *pos; > + unsigned long flags; > > seq_printf(s, "%s: %d\n", obj->name, obj->value); > > - spin_lock_irq(&obj->lock); > + spin_lock_irqsave(&obj->lock, flags); Exactly, it can be just spin_lock() as the irq state is known. Once again I question why this [sync_debug.c] code even exists. -Chris