From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
NXP Linux Team <linux-imx@nxp.com>,
Magnus Damm <magnus.damm@gmail.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Fabio Estevam <festevam@gmail.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] media: i2c: ov5645: Set maximum leverage of external clock frequency to 24480000
Date: Fri, 13 Mar 2020 21:12:33 +0000 [thread overview]
Message-ID: <1584133954-6953-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <1584133954-6953-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
While testing on Renesas RZ/G2E platform, noticed the clock frequency to
be 24242424 as a result the probe failed. However increasing the maximum
leverage of external clock frequency to 24480000 fixes this issue. Since
this difference is small enough and is insignificant set the same in the
driver.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/media/i2c/ov5645.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index 4fbabf3..b49359b 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -1107,8 +1107,10 @@ static int ov5645_probe(struct i2c_client *client)
}
xclk_freq = clk_get_rate(ov5645->xclk);
- /* external clock must be 24MHz, allow 1% tolerance */
- if (xclk_freq < 23760000 || xclk_freq > 24240000) {
+ /* external clock must be 24MHz, allow a minimum 1% and a maximum of 2%
+ * tolerance
+ */
+ if (xclk_freq < 23760000 || xclk_freq > 24480000) {
dev_err(dev, "external clock frequency %u is not supported\n",
xclk_freq);
return -EINVAL;
--
2.7.4
next prev parent reply other threads:[~2020-03-13 21:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:12 [PATCH v3 0/4] ov5645: Switch to assigned-clock-rates Lad Prabhakar
2020-03-13 21:12 ` [PATCH v3 1/4] media: dt-bindings: media: i2c: " Lad Prabhakar
2020-03-13 21:20 ` Laurent Pinchart
2020-03-13 21:25 ` Prabhakar Mahadev Lad
2020-03-13 21:27 ` Laurent Pinchart
2020-03-18 20:13 ` Lad, Prabhakar
2020-03-18 22:33 ` Laurent Pinchart
2020-03-18 22:37 ` Lad, Prabhakar
2020-03-19 12:44 ` Maxime Ripard
2020-03-19 13:03 ` Laurent Pinchart
2020-03-19 13:17 ` Lad, Prabhakar
2020-03-24 15:40 ` Maxime Ripard
2020-03-24 16:04 ` Lad, Prabhakar
2020-03-24 16:12 ` Laurent Pinchart
2020-03-25 21:52 ` Lad, Prabhakar
2020-03-19 13:05 ` Lad, Prabhakar
2020-03-13 21:12 ` [PATCH v3 2/4] media: i2c: ov5645: " Lad Prabhakar
2020-03-13 21:16 ` Laurent Pinchart
2020-03-13 21:19 ` Prabhakar Mahadev Lad
2020-03-13 21:12 ` Lad Prabhakar [this message]
2020-03-13 21:23 ` [PATCH v3 3/4] media: i2c: ov5645: Set maximum leverage of external clock frequency to 24480000 Laurent Pinchart
2020-03-13 21:31 ` Prabhakar Mahadev Lad
2020-03-18 22:41 ` Lad, Prabhakar
2020-03-18 23:22 ` Laurent Pinchart
2020-03-19 8:00 ` Lad, Prabhakar
2020-03-18 23:18 ` Laurent Pinchart
2020-03-19 7:59 ` Lad, Prabhakar
2020-03-13 21:12 ` [PATCH v3 4/4] ARM: dts: imx6qdl-wandboard: Switch to assigned-clock-rates for ov5645 node Lad Prabhakar
2020-03-13 21:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584133954-6953-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).