* [PATCH v2 0/2] DCMI BT656 parallel bus mode support
@ 2020-10-20 9:54 Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 1/2] media: stm32-dcmi: add support of BT656 bus Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656 Hugues Fruchet
0 siblings, 2 replies; 3+ messages in thread
From: Hugues Fruchet @ 2020-10-20 9:54 UTC (permalink / raw)
To: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
Sakari Ailus, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-media,
linux-stm32, Hugues Fruchet, Alain Volmat, Yannick Fertre,
Philippe CORNU
Add support of BT656 embedded synchronization bus.
This mode allows to save hardware synchro lines hsync & vsync
by replacing them with synchro codes embedded in data stream.
This mode is enabled when hsync-active & vsync-active
fields are not specified in devicetree.
===========
= history =
===========
version 2:
- As per Sakari remark, revisit commit message and document
BT656 parallel bus mode in bindings
version 1:
- Initial submission
Hugues Fruchet (2):
media: stm32-dcmi: add support of BT656 bus
media: dt-bindings: media: st,stm32-dcmi: Add support of BT656
.../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++++++++++++++++++
drivers/media/platform/stm32/stm32-dcmi.c | 37 ++++++++++++++++++++--
2 files changed, 65 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] media: stm32-dcmi: add support of BT656 bus
2020-10-20 9:54 [PATCH v2 0/2] DCMI BT656 parallel bus mode support Hugues Fruchet
@ 2020-10-20 9:54 ` Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656 Hugues Fruchet
1 sibling, 0 replies; 3+ messages in thread
From: Hugues Fruchet @ 2020-10-20 9:54 UTC (permalink / raw)
To: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
Sakari Ailus, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-media,
linux-stm32, Hugues Fruchet, Alain Volmat, Yannick Fertre,
Philippe CORNU
Add support of BT656 embedded synchronization busaaaaaaaaaaaaaaaaaaaaaaaaa
Add support of BT656 embedded synchronization bus.
This mode allows to save hardware synchro lines hsync & vsync by replacing
them with synchro codes embedded in data stream.
This bus type is only compatible with 8 bits width data bus.
Due to reserved values 0x00 & 0xff used for synchro codes, valid data vary
from 0x1 to 0xfe, this is up to sensor to clip accordingly pixel data. As
a consequence of this clipping, JPEG is not supported with this bus type.
DCMI crop feature is also not available with this bus type.
Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
---
drivers/media/platform/stm32/stm32-dcmi.c | 37 +++++++++++++++++++++++++++++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index fd1c41c..d7d7cdb 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -157,6 +157,7 @@ struct stm32_dcmi {
struct vb2_queue queue;
struct v4l2_fwnode_bus_parallel bus;
+ enum v4l2_mbus_type bus_type;
struct completion complete;
struct clk *mclk;
enum state state;
@@ -777,6 +778,23 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
if (dcmi->bus.flags & V4L2_MBUS_PCLK_SAMPLE_RISING)
val |= CR_PCKPOL;
+ /*
+ * BT656 embedded synchronisation bus mode.
+ *
+ * Default SAV/EAV mode is supported here with default codes
+ * SAV=0xff000080 & EAV=0xff00009d.
+ * With DCMI this means LSC=SAV=0x80 & LEC=EAV=0x9d.
+ */
+ if (dcmi->bus_type == V4L2_MBUS_BT656) {
+ val |= CR_ESS;
+
+ /* Unmask all codes */
+ reg_write(dcmi->regs, DCMI_ESUR, 0xffffffff);/* FEC:LEC:LSC:FSC */
+
+ /* Trig on LSC=0x80 & LEC=0x9d codes, ignore FSC and FEC */
+ reg_write(dcmi->regs, DCMI_ESCR, 0xff9d80ff);/* FEC:LEC:LSC:FSC */
+ }
+
reg_write(dcmi->regs, DCMI_CR, val);
/* Set crop */
@@ -1067,8 +1085,9 @@ static int dcmi_set_fmt(struct stm32_dcmi *dcmi, struct v4l2_format *f)
if (ret)
return ret;
- /* Disable crop if JPEG is requested */
- if (pix->pixelformat == V4L2_PIX_FMT_JPEG)
+ /* Disable crop if JPEG is requested or BT656 bus is selected */
+ if (pix->pixelformat == V4L2_PIX_FMT_JPEG &&
+ dcmi->bus_type != V4L2_MBUS_BT656)
dcmi->do_crop = false;
/* pix to mbus format */
@@ -1592,6 +1611,11 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)
if (dcmi_formats[i].mbus_code != mbus_code.code)
continue;
+ /* Exclude JPEG if BT656 bus is selected */
+ if (dcmi_formats[i].fourcc == V4L2_PIX_FMT_JPEG &&
+ dcmi->bus_type == V4L2_MBUS_BT656)
+ continue;
+
/* Code supported, have we got this fourcc yet? */
for (j = 0; j < num_fmts; j++)
if (sd_fmts[j]->fourcc ==
@@ -1873,9 +1897,18 @@ static int dcmi_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "CSI bus not supported\n");
return -ENODEV;
}
+
+ if (ep.bus_type == V4L2_MBUS_BT656 &&
+ ep.bus.parallel.bus_width != 8) {
+ dev_err(&pdev->dev, "BT656 bus conflicts with %d bits bus width (8 bits required)\n",
+ ep.bus.parallel.bus_width);
+ return -ENODEV;
+ }
+
dcmi->bus.flags = ep.bus.parallel.flags;
dcmi->bus.bus_width = ep.bus.parallel.bus_width;
dcmi->bus.data_shift = ep.bus.parallel.data_shift;
+ dcmi->bus_type = ep.bus_type;
irq = platform_get_irq(pdev, 0);
if (irq <= 0)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656
2020-10-20 9:54 [PATCH v2 0/2] DCMI BT656 parallel bus mode support Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 1/2] media: stm32-dcmi: add support of BT656 bus Hugues Fruchet
@ 2020-10-20 9:54 ` Hugues Fruchet
1 sibling, 0 replies; 3+ messages in thread
From: Hugues Fruchet @ 2020-10-20 9:54 UTC (permalink / raw)
To: Alexandre Torgue, Mauro Carvalho Chehab, Hans Verkuil,
Sakari Ailus, Rob Herring
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-media,
linux-stm32, Hugues Fruchet, Alain Volmat, Yannick Fertre,
Philippe CORNU
Add support of BT656 parallel bus mode in DCMI.
This mode is enabled when hsync-active & vsync-active
fields are not specified.
Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
---
.../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
index 3fe778c..1ee521a 100644
--- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
+++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
@@ -44,6 +44,36 @@ properties:
bindings defined in
Documentation/devicetree/bindings/media/video-interfaces.txt.
+ properties:
+ endpoint:
+ type: object
+
+ properties:
+ bus-width: true
+
+ hsync-active:
+ description:
+ If both HSYNC and VSYNC polarities are not specified, BT656
+ embedded synchronization is selected.
+ default: 0
+
+ vsync-active:
+ description:
+ If both HSYNC and VSYNC polarities are not specified, BT656
+ embedded synchronization is selected.
+ default: 0
+
+ pclk-sample: true
+
+ remote-endpoint: true
+
+ required:
+ - remote-endpoint
+
+ additionalProperties: false
+
+ additionalProperties: false
+
required:
- compatible
- reg
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 9:54 [PATCH v2 0/2] DCMI BT656 parallel bus mode support Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 1/2] media: stm32-dcmi: add support of BT656 bus Hugues Fruchet
2020-10-20 9:54 ` [PATCH v2 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656 Hugues Fruchet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).