From: Sean Young <sean@mess.org>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH 1/3] input: remove redundant check for EV_REP
Date: Fri, 24 Nov 2017 11:43:59 +0000 [thread overview]
Message-ID: <19939ec6f47e552c8c0b552d35cc0640a6af74f3.1511523174.git.sean@mess.org> (raw)
In-Reply-To: <cover.1511523174.git.sean@mess.org>
In-Reply-To: <cover.1511523174.git.sean@mess.org>
The caller input_pass_values has already checked this bit.
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/input/input.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 762bfb9487dc..ecc41d65b82a 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -74,9 +74,7 @@ static int input_defuzz_abs_event(int value, int old_val, int fuzz)
static void input_start_autorepeat(struct input_dev *dev, int code)
{
- if (test_bit(EV_REP, dev->evbit) &&
- dev->rep[REP_PERIOD] && dev->rep[REP_DELAY] &&
- dev->timer.data) {
+ if (dev->rep[REP_PERIOD] && dev->rep[REP_DELAY] && dev->timer.data) {
dev->repeat_key = code;
mod_timer(&dev->timer,
jiffies + msecs_to_jiffies(dev->rep[REP_DELAY]));
--
2.14.3
next prev parent reply other threads:[~2017-11-24 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 11:43 [PATCH 0/3] Improve CEC autorepeat handling Sean Young
2017-11-24 11:43 ` Sean Young [this message]
2017-11-24 11:44 ` [PATCH 2/3] input: handle case whether first repeated key triggers repeat Sean Young
2017-11-24 11:44 ` [PATCH 3/3] media: cec: move cec autorepeat handling to rc-core Sean Young
2017-11-25 23:47 ` [PATCH 0/3] Improve CEC autorepeat handling Dmitry Torokhov
2017-11-27 9:13 ` Hans Verkuil
2017-11-27 9:47 ` Sean Young
2017-11-27 10:01 ` Hans Verkuil
2017-11-27 10:11 ` Dmitry Torokhov
2017-11-27 15:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19939ec6f47e552c8c0b552d35cc0640a6af74f3.1511523174.git.sean@mess.org \
--to=sean@mess.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).