From: Jan Kotas <jank@cadence.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Jan Kotas <jank@cadence.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rafal Ciepiela <rafalc@cadence.com>,
linux-media <linux-media@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] media: Add lane checks for Cadence CSI2RX
Date: Mon, 9 Sep 2019 07:41:21 +0000 [thread overview]
Message-ID: <1D1666FD-CFC6-4DE1-8A2E-1809D1BDEAAB@global.cadence.com> (raw)
In-Reply-To: <20190906075413.GE1586@valkosipuli.retiisi.org.uk>
Hello Sakari,
Thanks for your reply.
> On 6 Sep 2019, at 09:54, Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Jan,
>
> Thanks for the patchset.
>
> On Thu, Sep 05, 2019 at 11:56:00AM +0100, Jan Kotas wrote:
>> /*
>> * Driver for Cadence MIPI-CSI2 RX Controller v1.3
>> *
>> - * Copyright (C) 2017 Cadence Design Systems Inc.
>> + * Copyright (C) 2017-2019 Cadence Design Systems Inc.
>> */
>>
>> + for (i = 0; i < csi2rx->num_lanes; i++) {
>> + if (csi2rx->lanes[i] < 1) {
>
> Do you need this? v4l2_fwnode_parse_endpoint() already has a more thorough
> check for the lane numbers.
I looked at the source code of v4l2_fwnode_endpoint_parse_csi2_bus
and this particular case doesn’t seem to be checked.
>
> --
> Regards,
>
> Sakari Ailus
Regards,
Jan
next prev parent reply other threads:[~2019-09-09 7:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:55 [PATCH v2 0/3] media: Add support for Cadence CSI2RX version 2.1 Jan Kotas
2019-09-05 10:55 ` [PATCH v2 1/3] media: dt-bindings: Update bindings for Cadence CSI2RX Jan Kotas
2019-09-17 20:52 ` Rob Herring
2019-09-05 10:56 ` [PATCH v2 2/3] media: Add lane checks " Jan Kotas
2019-09-06 7:54 ` Sakari Ailus
2019-09-09 7:41 ` Jan Kotas [this message]
2019-09-09 7:51 ` Sakari Ailus
2019-09-09 8:12 ` Jan Kotas
2019-09-09 9:40 ` Sakari Ailus
2019-09-05 10:56 ` [PATCH v2 3/3] media: Add support for Cadence CSI2RX 2.1 Jan Kotas
2019-09-06 8:01 ` Sakari Ailus
2019-09-09 9:24 ` Jan Kotas
2019-09-09 9:41 ` Sakari Ailus
2019-09-05 12:01 ` [PATCH v2 0/3] media: Add support for Cadence CSI2RX version 2.1 Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D1666FD-CFC6-4DE1-8A2E-1809D1BDEAAB@global.cadence.com \
--to=jank@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=rafalc@cadence.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).