From: Rajendra Nayak <rnayak@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: stanimir.varbanov@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: sc7180: Add OPP tables and power-domains for venus
Date: Thu, 2 Jul 2020 14:26:14 +0530 [thread overview]
Message-ID: <1ce702e1-6deb-8f13-3e17-38170b136b2c@codeaurora.org> (raw)
In-Reply-To: <20200701165414.GB3191083@google.com>
On 7/1/2020 10:24 PM, Matthias Kaehlcke wrote:
> On Wed, Jul 01, 2020 at 05:10:38PM +0530, Rajendra Nayak wrote:
>> Add the OPP tables in order to be able to vote on the performance state
>> of a power-domain
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 35 +++++++++++++++++++++++++++++++++--
>> 1 file changed, 33 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index ad57df2..738a741 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -2392,8 +2392,10 @@
>> reg = <0 0x0aa00000 0 0xff000>;
>> interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>> power-domains = <&videocc VENUS_GDSC>,
>> - <&videocc VCODEC0_GDSC>;
>> - power-domain-names = "venus", "vcodec0";
>> + <&videocc VCODEC0_GDSC>,
>> + <&rpmhpd SC7180_CX>;
>> + power-domain-names = "venus", "vcodec0", "opp-pd";
>> + operating-points-v2 = <&venus_opp_table>;
>> clocks = <&videocc VIDEO_CC_VENUS_CTL_CORE_CLK>,
>> <&videocc VIDEO_CC_VENUS_AHB_CLK>,
>> <&videocc VIDEO_CC_VENUS_CTL_AXI_CLK>,
>> @@ -2414,6 +2416,35 @@
>> video-encoder {
>> compatible = "venus-encoder";
>> };
>> +
>> + venus_opp_table: venus-opp-table {
>> + compatible = "operating-points-v2";
>> +
>> + opp-200000000 {
>> + opp-hz = /bits/ 64 <150000000>;
>> + required-opps = <&rpmhpd_opp_low_svs>;
>> + };
>> +
>> + opp-320000000 {
>> + opp-hz = /bits/ 64 <270000000>;
>> + required-opps = <&rpmhpd_opp_svs>;
>> + };
>> +
>> + opp-380000000 {
>> + opp-hz = /bits/ 64 <340000000>;
>> + required-opps = <&rpmhpd_opp_svs_l1>;
>> + };
>> +
>> + opp-444000000 {
>> + opp-hz = /bits/ 64 <434000000>;
>> + required-opps = <&rpmhpd_opp_nom>;
>> + };
>> +
>> + opp-533000000 {
>> + opp-hz = /bits/ 64 <500000000>;
>> + required-opps = <&rpmhpd_opp_turbo>;
>> + };
>
> the labels of the OPP nodes don't match the specified frequencies
Oops, I'll fix and respin.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-07-02 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 11:40 [PATCH 0/3] DVFS support for Venus Rajendra Nayak
2020-07-01 11:40 ` [PATCH 1/3] media: venus: core: Add support for opp tables/perf voting Rajendra Nayak
2020-07-01 11:40 ` [PATCH 2/3] arm64: dts: sdm845: Add OPP tables and power-domains for venus Rajendra Nayak
2020-07-01 16:45 ` Matthias Kaehlcke
2020-07-01 11:40 ` [PATCH 3/3] arm64: dts: sc7180: " Rajendra Nayak
2020-07-01 16:54 ` Matthias Kaehlcke
2020-07-02 8:56 ` Rajendra Nayak [this message]
2020-07-14 0:36 ` Matthias Kaehlcke
2020-07-16 3:08 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce702e1-6deb-8f13-3e17-38170b136b2c@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mka@chromium.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).