From: Hans Verkuil <hverkuil@xs4all.nl>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>, kernel@pengutronix.de
Subject: Re: [PATCH v7] media: imx: add mem2mem device
Date: Sat, 19 Jan 2019 10:28:57 +0100 [thread overview]
Message-ID: <1d1217c0-5203-1161-8fe8-b1d1eae5cb66@xs4all.nl> (raw)
In-Reply-To: <1547830276.3375.20.camel@pengutronix.de>
On 01/18/2019 05:51 PM, Philipp Zabel wrote:
> On Fri, 2019-01-18 at 12:18 +0100, Philipp Zabel wrote:
>> Hi Hans,
>>
>> On Fri, 2019-01-18 at 10:30 +0100, Hans Verkuil wrote:
>>> On 1/17/19 4:50 PM, Philipp Zabel wrote:
>>
>> [...]
>>>> +
>>>> +static const struct video_device ipu_csc_scaler_videodev_template = {
>>>> + .name = "ipu0_ic_pp mem2mem",
>>>
>>> I would expect to see something like 'imx-media-csc-scaler' as the name.
>>> Wouldn't that be more descriptive?
>>
>> Yes, thank you. I'll change this as well.
>
> Actually, this is overwritten a few lines later anyway:
>
> snprintf(vfd->name, sizeof(vfd->name), "ipu_ic_pp mem2mem");
>
> Not that it makes a difference. But I noticed that I chose this name for
> something close to consistency with the other IPU devices:
>
> $ cat /sys/class/video4linux/video*/name
> ipu_ic_pp mem2mem
> coda-encoder
> coda-decoder
> ipu1_ic_prpenc capture
> ipu1_ic_prpvf capture
> ipu2_ic_prpenc capture
> ipu2_ic_prpvf capture
> ipu1_csi0 capture
> ipu1_csi1 capture
> ipu2_csi0 capture
> ipu2_csi1 capture
>
> They all start with the IPU / subdevice (/ IC task) prefix.
> Maybe "ipu_ic_pp csc/scaler" would be more appropriate?
That will work for me.
Regards,
Hans
>
> regards
> Philipp
>
next prev parent reply other threads:[~2019-01-19 9:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:50 [PATCH v7] media: imx: add mem2mem device Philipp Zabel
2019-01-18 9:30 ` Hans Verkuil
2019-01-18 11:18 ` Philipp Zabel
2019-01-18 12:41 ` Hans Verkuil
2019-01-18 13:42 ` Philipp Zabel
2019-01-18 13:45 ` Hans Verkuil
2019-01-18 14:17 ` Philipp Zabel
2019-01-18 16:51 ` Philipp Zabel
2019-01-19 9:28 ` Hans Verkuil [this message]
2019-02-12 19:01 ` Tim Harvey
2019-02-13 17:22 ` Nicolas Dufresne
2019-02-15 11:10 ` Philipp Zabel
2019-02-15 16:24 ` Nicolas Dufresne
2019-02-15 23:36 ` Tim Harvey
2019-02-15 23:34 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1217c0-5203-1161-8fe8-b1d1eae5cb66@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).