From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A4B0C433E0 for ; Wed, 1 Jul 2020 11:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77DEC20702 for ; Wed, 1 Jul 2020 11:21:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="GNKFZPfk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730240AbgGALVP (ORCPT ); Wed, 1 Jul 2020 07:21:15 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:63123 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730228AbgGALVO (ORCPT ); Wed, 1 Jul 2020 07:21:14 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1593602474; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: From: Subject: Sender; bh=n9dv+4uh/SqsbO43SuymhrpHyZhUe1aTGaZYaxpJrSM=; b=GNKFZPfkt4XcAd5Y3xEpNNvl3C5snZIzY8rWtwksBtfQ6ses1QvOd0pcR9Me7Ay+qif77dkx fm7WQOeXlFSN/IHKPu8nMDlLXFWdBAatvuKPNQHtvLS1U1+du/knAcW/HfQ4qer7NfroX8a5 Jrz25A+V8Bf5C4ZJd34fy7dII90= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3ZjU0NiIsICJsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5efc718f8fe116ddd9e7ecec (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 01 Jul 2020 11:20:47 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2B195C433CB; Wed, 1 Jul 2020 11:20:46 +0000 (UTC) Received: from [10.50.36.152] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: rnayak) by smtp.codeaurora.org (Postfix) with ESMTPSA id 53A55C433C6; Wed, 1 Jul 2020 11:20:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 53A55C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=rnayak@codeaurora.org Subject: Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting From: Rajendra Nayak To: Rob Herring Cc: stanimir.varbanov@linaro.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org References: <1589349807-10163-1-git-send-email-rnayak@codeaurora.org> <20200527193638.GA2604206@bogus> <448cc4c0-0714-dc62-df19-7fa8fba91758@codeaurora.org> Message-ID: <1e8c07c8-0954-462a-cfe6-a1ccde1bedea@codeaurora.org> Date: Wed, 1 Jul 2020 16:50:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <448cc4c0-0714-dc62-df19-7fa8fba91758@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 6/1/2020 11:26 AM, Rajendra Nayak wrote: > > On 5/28/2020 1:06 AM, Rob Herring wrote: >> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote: >>> Add an optional power domain which when specified can be used for >>> setting the performance state of Venus. >>> >>> Signed-off-by: Rajendra Nayak >>> --- >>>   Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 6 +++++- >>>   Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++- >>>   2 files changed, 10 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml >>> index 764affa..ac1ed64 100644 >>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml >>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml >>> @@ -25,12 +25,16 @@ properties: >>>       maxItems: 1 >>>     power-domains: >>> -    maxItems: 2 >>> +    minItems: 2 >>> +    maxItems: 3 >>>     power-domain-names: >>> +    minItems: 2 >>> +    maxItems: 3 >>>       items: >>>         - const: venus >>>         - const: vcodec0 >>> +      - const: opp-pd >> >> Humm, looks suspicious. This is a phyical power island in this block? > > yes, this is used to represent the physical 'cx' power island in the SoC > (Its a shared power island, not a power island specific to this block) > that can be scaled to different 'performance levels' based on the frequency > the codec is expected to run at. Rob, Did you have any other concerns here? Should I be re-posting this? -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation