From: Arkadiusz Miskiewicz <a.miskiewicz@gmail.com>
To: jasondong <jason.dong@ite.com.tw>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] Add driver support for ITE IT9135 device
Date: Wed, 24 Aug 2011 22:27:34 +0200 [thread overview]
Message-ID: <201108242227.34816.a.miskiewicz@gmail.com> (raw)
In-Reply-To: <201108242008.57903.a.miskiewicz@gmail.com>
On Wednesday 24 of August 2011, Arkadiusz Miskiewicz wrote:
> On Friday 05 of August 2011, jasondong wrote:
> > This is DVB USB Linux driver for ITEtech IT9135 base USB TV module.
> > It supported the IT9135 AX and BX chip versions.
>
> Hi,
>
> The quick review by crop@freenode was:
>
> "I quick check it and didnt like much since it is not plitted logically
> correct, as usb-bridge, demod and tuner. now all are rather much one big
> blob".
>
> so I guess you have to split it into pieces in a way other dvb drivers
> already in kernel tree are done. Unfortunately I don't know which existing
> driver is the best example on how to do things.
More comments from irc:
"22:09 < crope> arekm: any current DVB USB driver. there is very many of
integrated (2-in-1, or 3-in-1) drivers which are splitted correctly
22:10 < crope> ec168, af9015, some dibcom models?, ce6320, rtl2831u
22:11 < crope> you *must* implement all logical parts as own drivers no matter
of those are integrated to one silicon or not. it is generally seen those
parts used are sold as not integrated too
22:12 < crope> for example that IT9135, I really think it uses af9033 demod,
which is sold as own part and also integrated to af9015. and very likely
IT9135
contains same USB-brdge than AF9035. only difference is
integrated tuner
22:13 < crope> so IT9135 == AF9035+ ITXXXX tuner in one package. when you
split driver correctly to logical parts you can use same drivers
22:14 < crope> and AF9035 == AF903XX USB-bridge + AF9033 demod
22:17 < crope> all DVB USB drivers we have consist of 2 parts (drivers). 1)
USB-interface driver (aka DVB USB) 2) demodulator driver 3) tuner driver
22:17 < crope> all DVB USB drivers we have consist of 3 parts (drivers). 1)
USB-interface driver (aka DVB USB) 2) demodulator driver 3) tuner driver
"
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
next prev parent reply other threads:[~2011-08-24 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 10:24 [PATCH 1/1] Add driver support for ITE IT9135 device jasondong
2011-08-06 9:51 ` [PATCH 1/2] IT9135 Add support for KWORLD_UB499_2T_T09 (id 1b80:e409) Malcolm Priestley
2011-08-06 9:52 ` [PATCH 2/2] IT9135 add MFE support to driver Malcolm Priestley
2011-08-24 18:08 ` [PATCH 1/1] Add driver support for ITE IT9135 device Arkadiusz Miskiewicz
2011-08-24 20:27 ` Arkadiusz Miskiewicz [this message]
2011-09-03 13:44 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108242227.34816.a.miskiewicz@gmail.com \
--to=a.miskiewicz@gmail.com \
--cc=jason.dong@ite.com.tw \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).