From: "David Härdeman" <david@hardeman.nu>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset
Date: Mon, 23 May 2016 21:01:06 +0200 [thread overview]
Message-ID: <20160523190106.GC6526@hardeman.nu> (raw)
In-Reply-To: <20160514170126.GU14068@earth.li>
On Sat, May 14, 2016 at 06:01:26PM +0100, Jonathan McDowell wrote:
>Fix RC5 decoding with Fintek CIR chipset
>
>Commit e87b540be2dd02552fb9244d50ae8b4e4619a34b tightened up the RC5
>decoding by adding a check for trailing silence to ensure a valid RC5
>command had been received. Unfortunately the trailer length checked was
>10 units and the Fintek CIR device does not want to provide details of a
>space longer than 6350us. This meant that RC5 remotes working on a
>Fintek setup on 3.16 failed on 3.17 and later. Fix this by shortening
>the trailer check to 6 units (allowing for a previous space in the
>received remote command).
>
>Signed-off-by: Jonathan McDowell <noodles@earth.li>
Signed-off-by: David Härdeman <david@hardeman.nu>
>Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221
>Cc: stable@vger.kernel.org
>
>-----
>diff --git a/drivers/media/rc/ir-rc5-decoder.c b/drivers/media/rc/ir-rc5-decoder.c
>index 6ffe776..a0fd4e6 100644
>--- a/drivers/media/rc/ir-rc5-decoder.c
>+++ b/drivers/media/rc/ir-rc5-decoder.c
>@@ -29,7 +29,7 @@
> #define RC5_BIT_START (1 * RC5_UNIT)
> #define RC5_BIT_END (1 * RC5_UNIT)
> #define RC5X_SPACE (4 * RC5_UNIT)
>-#define RC5_TRAILER (10 * RC5_UNIT) /* In reality, approx 100 */
>+#define RC5_TRAILER (6 * RC5_UNIT) /* In reality, approx 100 */
>
> enum rc5_state {
> STATE_INACTIVE,
>-----
>
>J.
>
>--
>What did the first punk rock girl wear to your school?
>
--
David Härdeman
prev parent reply other threads:[~2016-05-23 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 17:01 [PATCH] Fix RC5 decoding with Fintek CIR chipset Jonathan McDowell
2016-05-23 19:01 ` David Härdeman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523190106.GC6526@hardeman.nu \
--to=david@hardeman.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).