Re: [PATCH 8/8] [media] rcar-vin: add Gen2 and Gen3 fallback compatibility strings

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

Hi Sergei,

On 2016-05-25 22:36:02 +0300, Sergei Shtylyov wrote:
> On 05/25/2016 10:10 PM, Niklas Söderlund wrote:
> 
> > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > 
> > These are present in the soc-camera version of this driver and it's time
> > to add them to this driver as well.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> >  drivers/media/platform/rcar-vin/rcar-core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> > index 520690c..87041db 100644
> > --- a/drivers/media/platform/rcar-vin/rcar-core.c
> > +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> > @@ -33,6 +33,8 @@ static const struct of_device_id rvin_of_id_table[] = {
> >  	{ .compatible = "renesas,vin-r8a7790", .data = (void *)RCAR_GEN2 },
> >  	{ .compatible = "renesas,vin-r8a7779", .data = (void *)RCAR_H1 },
> >  	{ .compatible = "renesas,vin-r8a7778", .data = (void *)RCAR_M1 },
> > +	{ .compatible = "renesas,rcar-gen3-vin", .data = (void *)RCAR_GEN3 },
> > +	{ .compatible = "renesas,rcar-gen2-vin", .data = (void *)RCAR_GEN2 },
> 
>    What's the point of adding the H3 specific compatibility string in the
> previous patch then? The fallback stings were added not have to updated the
> driver for every new SoC exactly.

Since this driver aims to replace the previous R-Car VIN driver which 
uses soc-camera I think it also should contain all the compatibility 
strings that the soc-camera driver do.

Other then that I have no strong opining and are happy to drop the 
previous patch if the intended use of the fallback strings are to use 
them over a SoC specific one.

-- 
Regards,
Niklas Söderlund