From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47547 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756528AbcEaVel (ORCPT ); Tue, 31 May 2016 17:34:41 -0400 Date: Tue, 31 May 2016 23:34:37 +0200 From: Pavel Machek To: Sakari Ailus Cc: Ivaylo Dimitrov , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, linux-media@vger.kernel.org, mchehab@osg.samsung.com Subject: Re: [PATCHv5] support for AD5820 camera auto-focus coil Message-ID: <20160531213437.GA28397@amd> References: <20160517181927.GA28741@amd> <20160521054336.GA27123@amd> <573FFF51.1000004@gmail.com> <20160521105607.GA20071@amd> <574049EF.2090208@gmail.com> <20160524090433.GA1277@amd> <20160524091746.GA14536@amd> <20160525212659.GK26360@valkosipuli.retiisi.org.uk> <20160527205140.GA26767@amd> <20160531212222.GP26360@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160531212222.GP26360@valkosipuli.retiisi.org.uk> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed 2016-06-01 00:22:22, Sakari Ailus wrote: > Hi Pavel, > > On Fri, May 27, 2016 at 10:51:40PM +0200, Pavel Machek wrote: > > > > This adds support for AD5820 autofocus coil, found for example in > > Nokia N900 smartphone. > > > > Signed-off-by: Pavel Machek > > The patch looks good to me but then I came to think of a question I've > missed so far: is there DT documentation somewhere for the properties used > by the driver? I might put that to a separate patch, and cc the relevant > list. Well, it does not use any dt properties. So there's not really much to discuss with dt people... Maybe "ad5820" needs to go to list of simple i2c drivers somewhere, but... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html