linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	pali.rohar@gmail.com, sre@kernel.org,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
	aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com,
	linux-media@vger.kernel.org, mchehab@osg.samsung.com
Subject: Re: [PATCHv5] support for AD5820 camera auto-focus coil
Date: Thu, 2 Jun 2016 10:45:45 +0300	[thread overview]
Message-ID: <20160602074544.GR26360@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20160601220840.GA21946@amd>

On Thu, Jun 02, 2016 at 12:08:40AM +0200, Pavel Machek wrote:
> On Wed 2016-06-01 18:24:39, Sakari Ailus wrote:
> > Hi Pavel,
> 
> > > Well, it does not use any dt properties. So there's not really much to
> > > discuss with dt people...
> > > 
> > > Maybe "ad5820" needs to go to list of simple i2c drivers somewhere,
> > > but...
> > 
> > It's an I2C device and it does use a regulator. Not a lot, though, these are
> > both quite basic stuff. This should still be documented as the people who
> > write the DT bindings (in general) aren't expected to read driver code as
> > well. That's at least my understanding.
> 
> Yep, you are right, I forgot about the regulator. Something like this?
> 
> Thanks,
> 									Pavel
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ad5820.txt b/Documentation/devicetree/bindings/media/i2c/ad5820.txt
> new file mode 100644
> index 0000000..87c98f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ad5820.txt

I might use the compatible string as such as a part of the file name. Up to
you.

> @@ -0,0 +1,20 @@
> +* Analog Devices AD5820 autofocus coil
> +
> +Required Properties:
> +
> +  - compatible: Must contain "adi,ad5820"
> +
> +  - reg: I2C slave address
> +
> +  - VANA-supply: supply of voltage for VANA pin
> +
> +Example:
> +
> +       /* D/A converter for auto-focus */

There is definitely D/A conversion happening there but I'm not sure I'd
characterise the device as such. They're typically called "voice coil
drivers", perhaps because the devices are similar to a parts of a
loudspeaker.

> +       ad5820: dac@0c {
> +               compatible = "adi,ad5820";
> +               reg = <0x0c>;
> +
> +               VANA-supply = <&vaux4>;
> +       };
> +
> 
> 

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

  reply	other threads:[~2016-06-02  7:46 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 18:19 [PATCH] support for AD5820 camera auto-focus coil Pavel Machek
2016-05-17 18:33 ` Marcus Folkesson
2016-05-18  8:30   ` Pavel Machek
2016-05-21  5:43 ` [PATCHv2] " Pavel Machek
2016-05-21  6:25   ` Ivaylo Dimitrov
2016-05-21 10:56     ` [PATCHv3] " Pavel Machek
2016-05-21 11:43       ` Ivaylo Dimitrov
2016-05-23  7:41         ` Pali Rohár
2016-05-24  9:04         ` Pavel Machek
2016-05-24  9:16           ` Ivaylo Dimitrov
2016-05-24 20:20             ` Pavel Machek
2016-05-26  3:46               ` Ivaylo Dimitrov
2016-05-24  9:17           ` [PATCHv4] " Pavel Machek
2016-05-25 21:26             ` Sakari Ailus
2016-05-27 20:33               ` Pavel Machek
2016-05-27 20:51               ` [PATCHv5] " Pavel Machek
2016-05-31 21:22                 ` Sakari Ailus
2016-05-31 21:34                   ` Pavel Machek
2016-06-01 15:24                     ` Sakari Ailus
2016-06-01 22:08                       ` Pavel Machek
2016-06-02  7:45                         ` Sakari Ailus [this message]
2016-06-02 19:27                           ` Pavel Machek
2016-06-02 21:23                             ` Sakari Ailus
2016-06-02 19:30                           ` [PATCH] device tree description " Pavel Machek
2016-06-02 21:27                             ` Sakari Ailus
2016-06-03  6:19                               ` Pavel Machek
2016-06-05 19:07                               ` [PATCH] userspace API definitions for " Pavel Machek
2016-06-06  6:06                                 ` Ivaylo Dimitrov
2016-06-06  7:21                                   ` Pavel Machek
2016-06-11 22:06                                   ` Sakari Ailus
2016-06-12  7:54                                     ` Pavel Machek
2016-06-17 21:28                                       ` Sakari Ailus
2016-06-12  8:48                                     ` Pavel Machek
2016-06-12 11:22                                       ` Sakari Ailus
2016-06-13 19:17                                         ` Pavel Machek
2016-06-17 21:35                                           ` Sakari Ailus
2016-06-18 15:37                                             ` [PATCHv4] support for AD5820 camera " Pavel Machek
2016-06-18 15:38                                             ` [PATCH] userspace API definitions for " Pavel Machek
2016-07-12 23:32                                               ` Mauro Carvalho Chehab
2016-07-13  6:57                                                 ` Pavel Machek
2016-07-13  7:26                                                 ` Pavel Machek
2016-06-06 13:29                             ` [PATCH] device tree description for AD5820 camera " Rob Herring
2016-06-07  7:10                             ` [PATCHv2] " Pavel Machek
2016-06-09 22:37                               ` Sakari Ailus
2016-06-04 23:27                 ` [PATCHv5] support " kbuild test robot
2016-06-05  0:46                 ` kbuild test robot
2016-06-12 20:41                 ` [PATCH 1/1] v4l: Add camera voice coil lens control class, current control Sakari Ailus
2016-06-12 21:48                   ` Ivaylo Dimitrov
2016-06-17 22:11                     ` Pavel Machek
2016-06-17 22:39                       ` Laurent Pinchart
2016-06-18 11:28                         ` Pavel Machek
2016-06-17 22:06                   ` Pavel Machek
2016-08-05 10:26                 ` [PATCHv6] support for AD5820 camera auto-focus coil Pavel Machek
2016-08-05 10:30                   ` Pali Rohár
2016-08-08  8:09                   ` Sakari Ailus
2016-08-08 21:41                     ` Pavel Machek
2016-08-10 12:01                       ` Sakari Ailus
2016-08-08 23:23                         ` Pavel Machek
2016-08-11 11:16                           ` Sakari Ailus
2016-08-18 10:45                             ` Pavel Machek
2016-08-18 20:26                               ` Sakari Ailus
2016-08-18 21:28                                 ` Pavel Machek
2016-11-03 10:27                                 ` Pavel Machek
2016-11-03 21:49                                   ` Sakari Ailus
2016-11-04  7:45                                     ` Pavel Machek
2016-11-04 14:49                                       ` Tony Lindgren
2016-12-14 13:38                       ` Pali Rohár
2016-12-14 15:08                         ` Tony Lindgren
2016-12-15  6:50                           ` Sakari Ailus
2016-12-19 22:23                             ` Pavel Machek
2016-08-10  7:34                     ` Pali Rohár
2016-08-08 21:40                       ` Pavel Machek
2016-08-10 12:00                       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160602074544.GR26360@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=aaro.koskinen@iki.fi \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=serge@hallyn.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).