From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58035 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbcFRPit (ORCPT ); Sat, 18 Jun 2016 11:38:49 -0400 Date: Sat, 18 Jun 2016 17:38:46 +0200 From: Pavel Machek To: Sakari Ailus Cc: Ivaylo Dimitrov , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, patrikbachan@gmail.com, serge@hallyn.com, linux-media@vger.kernel.org, mchehab@osg.samsung.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH] userspace API definitions for auto-focus coil Message-ID: <20160618153846.GA15662@amd> References: <20160602074544.GR26360@valkosipuli.retiisi.org.uk> <20160602193027.GB7984@amd> <20160602212746.GT26360@valkosipuli.retiisi.org.uk> <20160605190716.GA11321@amd> <575512E5.5030000@gmail.com> <20160611220654.GC26360@valkosipuli.retiisi.org.uk> <20160612084811.GA27446@amd> <20160612112253.GD26360@valkosipuli.retiisi.org.uk> <20160613191753.GA17459@amd> <20160617213545.GH24980@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617213545.GH24980@valkosipuli.retiisi.org.uk> Sender: linux-media-owner@vger.kernel.org List-ID: Hi! > > Not V4L2_CID_USER_AD5820...? > > The rest of the controls have no USER as part of the macro name, so I > wouldn't use it here either. Ok. > > Ok, separate header file for 2 lines seemed like a bit of overkill, > > but why not. > > That follows an existing pattern of how controls have been implemented in > other drivers. Ok. > Could you merge this with the driver patch? I've dropped that from my ad5820 > branch as it does not compile. Yes, merged patch should be in your inbox now. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html