From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Randy Li <ayaka@soulik.info>
Cc: dri-devel@lists.freedesktop.org, randy.li@rock-chips.com,
linux-kernel@vger.kernel.org, daniel.vetter@intel.com,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] drm_fourcc: Add new P010 video format
Date: Wed, 4 Jan 2017 17:56:32 +0200 [thread overview]
Message-ID: <20170104155632.GI31595@intel.com> (raw)
In-Reply-To: <1483347004-32593-2-git-send-email-ayaka@soulik.info>
On Mon, Jan 02, 2017 at 04:50:03PM +0800, Randy Li wrote:
> P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits
> per channel video format. Rockchip's vop support this
> video format(little endian only) as the input video format.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
> include/uapi/drm/drm_fourcc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 9e1bb7f..d2721da 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -119,6 +119,7 @@ extern "C" {
> #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */
> #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */
> #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */
> +#define DRM_FORMAT_P010 fourcc_code('P', '0', '1', '0') /* 2x2 subsampled Cr:Cb plane 10 bits per channel */
We could use a better description of the format here. IIRC there is
10bits of actual data contained in each 16bits. So there should be a
proper comment explaning in which way the bits are stored.
>
> /*
> * 3 plane YCbCr
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2017-01-04 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 8:50 [PATCH 0/2] Add pixel format for 10 bits YUV video Randy Li
2017-01-02 8:50 ` [PATCH 1/2] drm_fourcc: Add new P010 video format Randy Li
2017-01-03 10:57 ` Daniel Stone
2017-01-04 15:56 ` Ville Syrjälä [this message]
2017-01-04 16:31 ` ayaka
2017-01-04 16:46 ` Ville Syrjälä
2017-01-02 8:50 ` [PATCH 2/2] [media] v4l: Add 10-bits per channel YUV pixel formats Randy Li
2017-01-02 9:10 ` Sakari Ailus
2017-01-02 10:53 ` ayaka
2017-01-02 11:07 ` Sakari Ailus
2017-01-02 13:03 ` ayaka
2017-01-03 10:49 ` Daniel Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104155632.GI31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ayaka@soulik.info \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=randy.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).