From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Mark Brown <broonie@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk
Date: Thu, 1 Jun 2017 22:58:24 +0200 [thread overview]
Message-ID: <20170601205850.24993-2-tiwai@suse.de> (raw)
In-Reply-To: <20170601205850.24993-1-tiwai@suse.de>
The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk
for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec
quirk for a MSI mobo. But it turned out that this isn't applied
properly due to the MSI-vendor quirk before this entry. I overlooked
such two MSI entries just because they were put in the wrong position,
although we have a list ordered by PCI SSID numbers.
This patch fixes it by rearranging the unordered entries.
Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo")
Reported-by: Rudolf Schmidt <info@rudolfschmidt.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 918e45268915..a57988d617e9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2324,11 +2324,11 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
SND_PCI_QUIRK(0x106b, 0x4a00, "Macbook 5,2", ALC889_FIXUP_MBA11_VREF),
SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC882_FIXUP_EAPD),
- SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
- SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD),
SND_PCI_QUIRK(0x1462, 0xda57, "MSI Z270-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
+ SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3),
SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX),
SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
--
2.13.0
next prev parent reply other threads:[~2017-06-01 20:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 20:58 [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Iwai
2017-06-01 20:58 ` Takashi Iwai [this message]
2017-06-02 5:36 ` [alsa-devel] [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Takashi Iwai
2017-06-02 9:12 ` Sergei Shtylyov
2017-06-01 20:58 ` [PATCH v2 02/27] ALSA: pcm: Introduce copy_user, copy_kernel and fill_silence ops Takashi Iwai
2017-06-02 17:14 ` Mark Brown
2017-06-01 20:58 ` [PATCH v2 03/27] ALSA: dummy: Convert to new PCM copy ops Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 04/27] ALSA: es1938: Convert to the " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 05/27] ALSA: nm256: Convert to " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 06/27] ALSA: korg1212: Convert to the new PCM ops Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 07/27] ALSA: rme32: Convert to the new PCM copy ops Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 08/27] ALSA: rme96: Convert to the new PCM ops Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 09/27] ALSA: rme9652: " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 10/27] ALSA: hdsp: " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 11/27] ALSA: gus: " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 12/27] ALSA: sb: " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 13/27] ALSA: sh: " Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 14/27] ASoC: blackfin: " Takashi Iwai
2017-06-02 17:14 ` Mark Brown
2017-06-01 20:58 ` [PATCH v2 15/27] [media] solo6x10: " Takashi Iwai
2017-06-01 21:30 ` Hans Verkuil
2017-06-01 20:58 ` [PATCH v2 16/27] ALSA: pcm: Drop the old copy and silence ops Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 17/27] ALSA: pcm: Check PCM state by a common helper function Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 18/27] ALSA: pcm: Shuffle codes Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 19/27] ALSA: pcm: Call directly the common read/write helpers Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 20/27] ALSA: pcm: More unification of PCM transfer codes Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 21/27] ALSA: pcm: Unify read/write loop Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 22/27] ALSA: pcm: Simplify snd_pcm_playback_silence() Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 23/27] ALSA: pcm: Direct in-kernel read/write support Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage Takashi Iwai
2017-06-01 23:48 ` Greg Kroah-Hartman
2017-06-01 20:58 ` [PATCH v2 25/27] ALSA: pcm: Kill set_fs() in PCM OSS layer Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 26/27] ALSA: pcm: Build OSS writev/readv helpers conditionally Takashi Iwai
2017-06-01 20:58 ` [PATCH v2 27/27] ALSA: doc: Update copy_user, copy_kernel and fill_silence PCM ops Takashi Iwai
2017-06-02 7:13 ` [PATCH v2 00/27] Revised full patchset for PCM in-kernel copy support Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601205850.24993-2-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).