From: Ismael Luceno <ismael@iodev.co.uk>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, mchehab@kernel.org,
maintainers@bluecherrydvr.com, anton@corp.bluecherry.net,
andrey.utkin@corp.bluecherry.net, hverkuil@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] [media] solo6x10: make video_device const
Date: Mon, 28 Aug 2017 15:41:37 -0300 [thread overview]
Message-ID: <20170828184136.GA9847@pirotess.bf.iodev.co.uk> (raw)
In-Reply-To: <1503746014-16489-4-git-send-email-bhumirks@gmail.com>
On 26/Aug/2017 16:43, Bhumika Goyal wrote:
> Make this const as it is only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-v4l2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2.c b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> index 3266fc2..99ffd1e 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2.c
> @@ -630,7 +630,7 @@ static int solo_s_ctrl(struct v4l2_ctrl *ctrl)
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> };
>
> -static struct video_device solo_v4l2_template = {
> +static const struct video_device solo_v4l2_template = {
> .name = SOLO6X10_NAME,
> .fops = &solo_v4l2_fops,
> .ioctl_ops = &solo_v4l2_ioctl_ops,
> --
> 1.9.1
>
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
next prev parent reply other threads:[~2017-08-28 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 11:13 [PATCH 0/5] [media] PCI: make video_device const Bhumika Goyal
2017-08-26 11:13 ` [PATCH 1/5] [media] meye: " Bhumika Goyal
2017-08-26 11:13 ` [PATCH 2/5] [media] saa7134: " Bhumika Goyal
2017-08-26 11:13 ` [PATCH 3/5] [media] solo6x10: " Bhumika Goyal
2017-08-28 18:41 ` Ismael Luceno [this message]
2017-08-26 11:13 ` [PATCH 4/5] [media] sta2x11: " Bhumika Goyal
2017-08-26 11:13 ` [PATCH 5/5] [media] tw68: " Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828184136.GA9847@pirotess.bf.iodev.co.uk \
--to=ismael@iodev.co.uk \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=anton@corp.bluecherry.net \
--cc=bhumirks@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).