From: Mika Westerberg <mika.westerberg@intel.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,
robh@kernel.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org
Subject: Re: [PATCH v9 17/24] ACPI: Document how to refer to LEDs from remote nodes
Date: Fri, 8 Sep 2017 16:58:03 +0300 [thread overview]
Message-ID: <20170908135803.GD2477@lahna.fi.intel.com> (raw)
In-Reply-To: <20170908135407.qxustmjr3yqhp7y5@valkosipuli.retiisi.org.uk>
On Fri, Sep 08, 2017 at 04:54:07PM +0300, Sakari Ailus wrote:
> On Fri, Sep 08, 2017 at 04:43:20PM +0300, Mika Westerberg wrote:
> > On Fri, Sep 08, 2017 at 04:18:15PM +0300, Sakari Ailus wrote:
> > > + Device (LED)
> > > + {
> > > + Name ((_DSD), Package () {
> > > + ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
> > > + Package () {
> > > + Package () { "led0", "LED0" },
> > > + Package () { "led1", "LED1" },
> > > + }
> > > + })
> > > + Name ((LED0), Package () {
> > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > + Package () {
> > > + Package () { "led", 0 },
> > > + Package () { "flash-max-microamp", 1000000 },
> > > + Package () { "led-max-microamp", 100000 },
> > > + Package () { "label", "led:salama" },
> > > + }
> > > + })
> > > + Name ((LED1), Package () {
> > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > + Package () {
> > > + Package () { "led", 1 },
> > > + Package () { "led-max-microamp", 10000 },
> > > + Package () { "label", "led:huomiovalo" },
> > > + }
> > > + })
> > > + }
> > > +
> > > + Device (SEN)
> > > + {
> > > + Name ((_DSD), Package () {
> > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > > + Package () {
> > > + Package () {
> > > + "flash-leds",
> > > + Package () { \\LED, 0, \\LED, 1 },
> > > + }
> > > + }
> > > + })
> > > + }
> >
> > You should probably try to compile these examples first ;-)
>
> Do you think I'm missing something else than s/\\\\/^/g ? :-)
Well, you should write
Name (_DSD, Package () {
instead of
Name ((_DSD), Package () {
but I guess the compiler accepts the former. However, please fix it and
make sure it compiles without issues so that we get good, working
examples.
next prev parent reply other threads:[~2017-09-08 13:58 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 13:11 [PATCH v9 00/23] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-08 13:11 ` [PATCH v9 01/24] v4l: fwnode: Move KernelDoc documentation to the header Sakari Ailus
2017-09-08 13:11 ` [PATCH v9 02/24] v4l: async: Remove re-probing support Sakari Ailus
2017-09-09 15:36 ` Laurent Pinchart
2017-09-11 7:47 ` Hans Verkuil
2017-09-11 7:51 ` Sakari Ailus
2017-09-08 13:11 ` [PATCH v9 03/24] v4l: async: Use more intuitive names for internal functions Sakari Ailus
2017-09-09 9:15 ` Pavel Machek
2017-09-09 15:34 ` Laurent Pinchart
2017-09-11 7:51 ` Hans Verkuil
2017-09-08 13:11 ` [PATCH v9 04/24] v4l: async: Add V4L2 async documentation to the documentation build Sakari Ailus
2017-09-09 15:37 ` Laurent Pinchart
2017-09-08 13:18 ` [PATCH v9 05/24] v4l: fwnode: Support generic parsing of graph endpoints in a device Sakari Ailus
2017-09-11 7:59 ` Hans Verkuil
2017-09-08 13:18 ` [PATCH v9 06/24] omap3isp: Use generic parser for parsing fwnode endpoints Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 07/24] rcar-vin: " Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 08/24] omap3isp: Fix check for our own sub-devices Sakari Ailus
2017-09-09 9:16 ` Pavel Machek
2017-09-08 13:18 ` [PATCH v9 09/24] omap3isp: Print the name of the entity where no source pads could be found Sakari Ailus
2017-09-09 9:16 ` Pavel Machek
2017-09-08 13:18 ` [PATCH v9 10/24] v4l: async: Move async subdev notifier operations to a separate structure Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 11/24] v4l: async: Introduce helpers for calling async ops callbacks Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 12/24] v4l: async: Register sub-devices before calling bound callback Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 13/24] v4l: async: Allow async notifier register call succeed with no subdevs Sakari Ailus
2017-09-11 8:05 ` Hans Verkuil
2017-09-11 8:21 ` Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 14/24] v4l: async: Allow binding notifiers to sub-devices Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 15/24] dt: bindings: Add a binding for flash LED devices associated to a sensor Sakari Ailus
2017-09-09 9:08 ` Pavel Machek
2017-09-08 13:18 ` [PATCH v9 16/24] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 17/24] ACPI: Document how to refer to LEDs from remote nodes Sakari Ailus
2017-09-08 13:43 ` Mika Westerberg
2017-09-08 13:54 ` Sakari Ailus
2017-09-08 13:58 ` Mika Westerberg [this message]
2017-09-09 9:08 ` Pavel Machek
2017-09-08 13:18 ` [PATCH v9 18/24] as3645a: Switch to fwnode property API Sakari Ailus
2017-09-09 9:19 ` Pavel Machek
2017-09-09 19:06 ` Jacek Anaszewski
2017-09-09 21:36 ` Sakari Ailus
2017-09-11 21:10 ` Jacek Anaszewski
2017-09-08 13:18 ` [PATCH v9 19/24] v4l: fwnode: Add a helper function for parsing generic references Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 20/24] v4l: fwnode: Add a helper function to obtain device / interger references Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 21/24] v4l: fwnode: Add convenience function for parsing common external refs Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 22/24] smiapp: Add support for flash and lens devices Sakari Ailus
2017-09-09 21:47 ` [RFC] et8ek8: " Pavel Machek
2017-09-09 22:06 ` Sakari Ailus
2017-09-11 13:18 ` [PATCH] " Pavel Machek
2017-09-12 11:06 ` Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 23/24] dt: bindings: smiapp: Document lens-focus and flash properties Sakari Ailus
2017-09-08 13:36 ` Pavel Machek
2017-09-08 13:42 ` Sakari Ailus
2017-09-08 21:45 ` Pavel Machek
2017-09-11 7:45 ` Sakari Ailus
2017-09-08 13:18 ` [PATCH v9 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera Sakari Ailus
2017-09-09 18:32 ` Pavel Machek
2017-09-09 22:13 ` Sakari Ailus
2017-09-08 13:25 ` [PATCH v9 00/23] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS Sakari Ailus
2017-09-09 9:34 ` Pavel Machek
2017-09-11 8:24 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908135803.GD2477@lahna.fi.intel.com \
--to=mika.westerberg@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).