linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-leds@vger.kernel.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, pavel@ucw.cz
Subject: [RESEND PATCH v2 6/6] as3645a: Unregister indicator LED on device unbind
Date: Mon, 18 Sep 2017 13:23:49 +0300	[thread overview]
Message-ID: <20170918102349.8935-7-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20170918102349.8935-1-sakari.ailus@linux.intel.com>

The indicator LED was registered in probe but was not removed in driver
remove callback. Fix this.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/leds/leds-as3645a.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index edeb0a499f6c..9494ba26c64b 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -743,6 +743,7 @@ static int as3645a_remove(struct i2c_client *client)
 	as3645a_set_control(flash, AS_MODE_EXT_TORCH, false);
 
 	v4l2_flash_release(flash->vf);
+	v4l2_flash_release(flash->vfind);
 
 	led_classdev_flash_unregister(&flash->fled);
 	led_classdev_unregister(&flash->iled_cdev);
-- 
2.11.0

      parent reply	other threads:[~2017-09-18 10:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 10:23 [RESEND PATCH v2 0/6] AS3645A fixes Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 1/6] as3645a: Use ams,input-max-microamp as documented in DT bindings Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 2/6] dt: bindings: as3645a: Use LED number to refer to LEDs Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 3/6] as3645a: Use integer numbers for parsing LEDs Sakari Ailus
2017-09-18 10:23 ` [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example Sakari Ailus
2017-09-18 10:56   ` Pavel Machek
2017-09-18 14:49     ` Sakari Ailus
2017-09-18 20:54       ` Pavel Machek
2017-09-19 21:01         ` Jacek Anaszewski
2017-09-20 20:53           ` Rob Herring
2017-09-22 21:07             ` Jacek Anaszewski
2017-09-23 21:12               ` Jacek Anaszewski
2017-11-18 13:38                 ` Jacek Anaszewski
2017-09-18 10:23 ` [RESEND PATCH v2 5/6] as3645a: Add colour to LED name Sakari Ailus
2017-09-18 10:23 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170918102349.8935-7-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).