From: kbuild test robot <lkp@intel.com>
To: Jacob Chen <jacob-chen@iotwrt.com>
Cc: kbuild-all@01.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
hans.verkuil@cisco.com, tfiga@chromium.org,
zhengsq@rock-chips.com, laurent.pinchart@ideasonboard.com,
zyc@rock-chips.com, eddie.cai.linux@gmail.com,
jeffy.chen@rock-chips.com, allon.huang@rock-chips.com,
devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org,
Jacob Chen <jacob2.chen@rock-chips.com>
Subject: Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver
Date: Mon, 27 Nov 2017 02:13:16 +0800 [thread overview]
Message-ID: <201711270219.rDGPDfrf%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171124023706.5702-5-jacob-chen@iotwrt.com>
[-- Attachment #1: Type: text/plain, Size: 5530 bytes --]
Hi Jacob,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20171124]
[cannot apply to rockchip/for-next v4.14]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jacob-Chen/Rockchip-ISP1-Driver/20171126-224713
base: git://linuxtv.org/media_tree.git master
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips
All errors (new ones prefixed by >>):
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:634:66: error: expected identifier or '(' before '=' token
struct v4l2_async_notifier_operationsrockchip_mipidphy_async_ops = {
^
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c: In function 'rockchip_mipidphy_media_init':
>> drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:707:24: error: 'rockchip_mipidphy_async_ops' undeclared (first use in this function); did you mean 'rockchip_mipidphy_match_id'?
priv->notifier.ops = &rockchip_mipidphy_async_ops;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
rockchip_mipidphy_match_id
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:707:24: note: each undeclared identifier is reported only once for each function it appears in
At top level:
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:593:1: warning: 'rockchip_mipidphy_notifier_complete' defined but not used [-Wunused-function]
rockchip_mipidphy_notifier_complete(struct v4l2_async_notifier *notifier)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:579:1: warning: 'rockchip_mipidphy_notifier_unbind' defined but not used [-Wunused-function]
rockchip_mipidphy_notifier_unbind(struct v4l2_async_notifier *notifier,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c:555:1: warning: 'rockchip_mipidphy_notifier_bound' defined but not used [-Wunused-function]
rockchip_mipidphy_notifier_bound(struct v4l2_async_notifier *notifier,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +707 drivers/media/platform/rockchip/isp1/mipi_dphy_sy.c
632
633 static const
> 634 struct v4l2_async_notifier_operationsrockchip_mipidphy_async_ops = {
635 .bound = rockchip_mipidphy_notifier_bound,
636 .unbind = rockchip_mipidphy_notifier_unbind,
637 .complete = rockchip_mipidphy_notifier_complete,
638 };
639
640 static int rockchip_mipidphy_fwnode_parse(struct device *dev,
641 struct v4l2_fwnode_endpoint *vep,
642 struct v4l2_async_subdev *asd)
643 {
644 struct sensor_async_subdev *s_asd =
645 container_of(asd, struct sensor_async_subdev, asd);
646 struct v4l2_mbus_config *config = &s_asd->mbus;
647
648 if (vep->bus_type != V4L2_MBUS_CSI2) {
649 dev_err(dev, "Only CSI2 bus type is currently supported\n");
650 return -EINVAL;
651 }
652
653 if (vep->base.port != 0) {
654 dev_err(dev, "The PHY has only port 0\n");
655 return -EINVAL;
656 }
657
658 config->type = V4L2_MBUS_CSI2;
659 config->flags = vep->bus.mipi_csi2.flags;
660 s_asd->lanes = vep->bus.mipi_csi2.num_data_lanes;
661
662 switch (vep->bus.mipi_csi2.num_data_lanes) {
663 case 1:
664 config->flags |= V4L2_MBUS_CSI2_1_LANE;
665 break;
666 case 2:
667 config->flags |= V4L2_MBUS_CSI2_2_LANE;
668 break;
669 case 3:
670 config->flags |= V4L2_MBUS_CSI2_3_LANE;
671 break;
672 case 4:
673 config->flags |= V4L2_MBUS_CSI2_4_LANE;
674 break;
675 default:
676 return -EINVAL;
677 }
678
679 return 0;
680 }
681
682 static int rockchip_mipidphy_media_init(struct mipidphy_priv *priv)
683 {
684 int ret;
685
686 priv->pads[MIPI_DPHY_SY_PAD_SOURCE].flags =
687 MEDIA_PAD_FL_SOURCE | MEDIA_PAD_FL_MUST_CONNECT;
688 priv->pads[MIPI_DPHY_SY_PAD_SINK].flags =
689 MEDIA_PAD_FL_SINK | MEDIA_PAD_FL_MUST_CONNECT;
690
691 ret = media_entity_pads_init(&priv->sd.entity,
692 MIPI_DPHY_SY_PADS_NUM, priv->pads);
693 if (ret < 0)
694 return ret;
695
696 ret = v4l2_async_notifier_parse_fwnode_endpoints_by_port(
697 priv->dev, &priv->notifier,
698 sizeof(struct sensor_async_subdev), 0,
699 rockchip_mipidphy_fwnode_parse);
700 if (ret < 0)
701 return ret;
702
703 if (!priv->notifier.num_subdevs)
704 return -ENODEV; /* no endpoint */
705
706 priv->sd.subdev_notifier = &priv->notifier;
> 707 priv->notifier.ops = &rockchip_mipidphy_async_ops;
708 ret = v4l2_async_subdev_notifier_register(&priv->sd, &priv->notifier);
709 if (ret) {
710 dev_err(priv->dev,
711 "failed to register async notifier : %d\n", ret);
712 v4l2_async_notifier_cleanup(&priv->notifier);
713 return ret;
714 }
715
716 return v4l2_async_register_subdev(&priv->sd);
717 }
718
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47597 bytes --]
next prev parent reply other threads:[~2017-11-26 18:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 2:36 [PATCH v2 00/11] Rockchip ISP1 Driver Jacob Chen
2017-11-24 2:36 ` [PATCH v2 01/11] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Jacob Chen
2017-11-27 10:17 ` Hans Verkuil
2017-11-24 2:36 ` [PATCH v2 02/11] media: rkisp1: Add user space ABI definitions Jacob Chen
2017-11-27 10:26 ` Hans Verkuil
2017-11-28 5:58 ` Jacob Chen
2017-11-24 2:36 ` [PATCH v2 03/11] media: rkisp1: add rockchip isp1 driver Jacob Chen
2017-11-26 17:32 ` kbuild test robot
2017-11-27 11:40 ` Hans Verkuil
2017-11-24 2:36 ` [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Jacob Chen
2017-11-26 17:04 ` kbuild test robot
2017-11-26 18:13 ` kbuild test robot [this message]
2017-11-27 12:01 ` Hans Verkuil
2017-11-27 14:15 ` Jose Abreu
2017-11-29 8:38 ` Jacob Chen
2017-11-24 2:37 ` [PATCH v2 05/11] dt-bindings: Document the Rockchip ISP1 bindings Jacob Chen
2017-11-26 22:14 ` Rob Herring
2017-11-24 2:37 ` [PATCH v2 06/11] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Jacob Chen
2017-11-26 22:16 ` Rob Herring
2017-11-24 2:37 ` [PATCH v2 07/11] ARM: dts: rockchip: add isp node for rk3288 Jacob Chen
2017-11-24 2:37 ` [PATCH v2 08/11] ARM: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2017-11-24 2:37 ` [PATCH v2 09/11] arm64: dts: rockchip: add isp0 node for rk3399 Jacob Chen
2017-11-24 2:37 ` [PATCH v2 10/11] arm64: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2017-11-24 2:37 ` [PATCH v2 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Jacob Chen
2017-11-24 6:15 ` [PATCH v2 00/11] Rockchip ISP1 Driver Jacob Chen
2017-11-24 2:49 [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Jacob Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711270219.rDGPDfrf%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=allon.huang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kbuild-all@01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).