linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Sowden <jeremy@azazel.net>
To: linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Cc: Jeremy Sowden <jeremy@azazel.net>
Subject: [PATCH v2 2/3] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings.
Date: Mon, 27 Nov 2017 12:44:49 +0000	[thread overview]
Message-ID: <20171127124450.28799-3-jeremy@azazel.net> (raw)
In-Reply-To: <20171127124450.28799-1-jeremy@azazel.net>

Defined some const arrays as static since they don't need external linkage.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 .../isp/kernels/eed1_8/ia_css_eed1_8.host.c        | 24 +++++++++++-----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c
index 682f8b709ff9..47bb5042381b 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/eed1_8/ia_css_eed1_8.host.c
@@ -32,44 +32,44 @@
 #define NUMBER_OF_TCINV_POINTS 9
 #define NUMBER_OF_FCINV_POINTS 9
 
-const int16_t chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = {
 0, 16, 64, 144, 272, 448, 672, 976,
 1376, 1888, 2528, 3312, 4256, 5376, 6688};
 
-const int16_t chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = {
 -7171, -256, -29, -3456, -1071, -475, -189, -102,
 -48, -38, -10, -9, -7, -6, 0};
 
-const int16_t chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = {
 8191, 1021, 256, 114, 60, 37, 24, 17,
 12, 9, 6, 5, 4, 3, 2};
 
-const int16_t chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = {
+static const int16_t chgrinv_c[NUMBER_OF_CHGRINV_POINTS] = {
 1, 1, 1, 0, 0, 0, 0, 0,
 0, 0, 0, 0, 0, 0, 0};
 
-const int16_t tcinv_x[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_x[NUMBER_OF_TCINV_POINTS] = {
 0, 4, 11, 23, 42, 68, 102, 148, 205};
 
-const int16_t tcinv_a[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_a[NUMBER_OF_TCINV_POINTS] = {
 -6364, -631, -126, -34, -13, -6, -4452, -2156, 0};
 
-const int16_t tcinv_b[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_b[NUMBER_OF_TCINV_POINTS] = {
 8191, 1828, 726, 352, 197, 121, 80, 55, 40};
 
-const int16_t tcinv_c[NUMBER_OF_TCINV_POINTS] = {
+static const int16_t tcinv_c[NUMBER_OF_TCINV_POINTS] = {
 1, 1, 1, 1, 1, 1, 0, 0, 0};
 
-const int16_t fcinv_x[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_x[NUMBER_OF_FCINV_POINTS] = {
 0, 80, 216, 456, 824, 1344, 2040, 2952, 4096};
 
-const int16_t fcinv_a[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_a[NUMBER_OF_FCINV_POINTS] = {
 -5244, -486, -86, -2849, -961, -400, -180, -86, 0};
 
-const int16_t fcinv_b[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_b[NUMBER_OF_FCINV_POINTS] = {
 8191, 1637, 607, 287, 159, 98, 64, 44, 32};
 
-const int16_t fcinv_c[NUMBER_OF_FCINV_POINTS] = {
+static const int16_t fcinv_c[NUMBER_OF_FCINV_POINTS] = {
 1, 1, 1, 0, 0, 0, 0, 0, 0};
 
 
-- 
2.15.0

  parent reply	other threads:[~2017-11-27 12:45 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 11:30 [PATCH 0/3] Sparse fixes for the Atom ISP Staging Driver Jeremy Sowden
2017-11-27 11:30 ` [PATCH 1/3] media: staging: atomisp: address member of struct ia_css_host_data is a pointer-to-char, so define default as NULL Jeremy Sowden
2017-11-27 11:30 ` [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage Jeremy Sowden
2017-11-27 12:21   ` Greg KH
2017-11-27 12:44     ` [PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver Jeremy Sowden
2017-11-27 12:44       ` [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings Jeremy Sowden
2017-11-28 14:15         ` Dan Carpenter
2017-11-28 23:33           ` Jeremy Sowden
2017-11-29  0:04             ` Dan Carpenter
2017-11-29  8:38               ` Jeremy Sowden
2017-11-29 13:58                 ` Alan Cox
2017-11-30 21:40                 ` [PATCH 0/3] Clean up of data-structure initialization in the CSS API Jeremy Sowden
2017-11-30 21:40                   ` [PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers Jeremy Sowden
2017-12-01 15:07                     ` Dan Carpenter
2017-12-01 15:31                       ` Jeremy Sowden
2017-12-01 17:19                       ` [PATCH v2 0/3] media: atomisp: clean up of data-structure initialization in the CSS API Jeremy Sowden
2017-12-01 17:19                         ` [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers Jeremy Sowden
2017-12-02 10:20                           ` Dan Carpenter
2017-12-02 10:35                             ` Jeremy Sowden
2017-12-02 20:41                               ` Jeremy Sowden
2017-12-02 21:34                                 ` Jeremy Sowden
2017-12-02 22:11                                   ` [PATCH v4 0/3] media: atomisp: clean up of data-structure initialization in the CSS API Jeremy Sowden
2017-12-02 22:11                                     ` [PATCH v4 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers Jeremy Sowden
2017-12-19 12:07                                       ` Sakari Ailus
2017-12-21 19:31                                         ` Jeremy Sowden
2017-12-02 22:12                                     ` [PATCH v4 2/3] media: atomisp: delete zero-valued struct members Jeremy Sowden
2017-12-02 22:12                                     ` [PATCH v4 3/3] media: atomisp: delete empty default struct values Jeremy Sowden
2017-12-19 12:08                                       ` Sakari Ailus
2017-12-03  5:39                                 ` [PATCH v2 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers Dan Carpenter
2017-12-03 10:54                                   ` Jeremy Sowden
2017-12-01 17:19                         ` [PATCH v2 2/3] media: atomisp: delete zero-valued struct members Jeremy Sowden
2017-12-01 17:41                           ` Alan Cox
2017-12-02 15:00                             ` Jeremy Sowden
2017-12-01 17:19                         ` [PATCH v2 3/3] media: atomisp: delete empty default struct values Jeremy Sowden
2017-12-01 21:45                       ` [PATCH v3 0/3] media: atomisp: clean up of data-structure initialization in the CSS API Jeremy Sowden
2017-12-01 21:45                         ` [PATCH v3 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers Jeremy Sowden
2017-12-01 21:45                         ` [PATCH v3 2/3] media: atomisp: delete zero-valued struct members Jeremy Sowden
2017-12-01 21:45                         ` [PATCH v3 3/3] media: atomisp: delete empty default struct values Jeremy Sowden
2017-11-30 21:40                   ` [PATCH 2/3] media: atomisp: delete zero-valued struct members Jeremy Sowden
2017-11-30 21:40                   ` [PATCH 3/3] media: atomisp: delete empty default struct values Jeremy Sowden
2017-11-27 12:44       ` Jeremy Sowden [this message]
2017-11-27 12:44       ` [PATCH v2 3/3] media: staging: atomisp: fixed some checkpatch integer type warnings Jeremy Sowden
2017-11-27 19:09         ` Alan Cox
2017-11-27 22:02           ` Jeremy Sowden
2017-11-28 10:27           ` [PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver Jeremy Sowden
2017-11-28 10:27             ` [PATCH v3 1/2] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings Jeremy Sowden
2017-11-28 10:27             ` [PATCH v3 2/2] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings Jeremy Sowden
2017-11-29  8:48             ` [PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver Sakari Ailus
2017-11-29  9:08     ` [PATCH 2/3] media: staging: atomisp: defined as static some const arrays which don't need external linkage Sakari Ailus
2017-11-29  9:15       ` Greg KH
2017-11-29  9:26         ` Sakari Ailus
2017-11-27 11:30 ` [PATCH 3/3] media: staging: atomisp: prefer s16 to int16_t Jeremy Sowden
2017-11-29  8:47   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127124450.28799-3-jeremy@azazel.net \
    --to=jeremy@azazel.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).