From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Mauro Carvalho Chehab" <mchehab@infradead.org>,
lkml@vger.kernel.org, "Sean Young" <sean@mess.org>,
"Philippe Ombredanne" <pombredanne@nexb.com>,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Colin Ian King" <colin.king@canonical.com>,
"Andi Shyti" <andi.shyti@samsung.com>,
"David Härdeman" <david@hardeman.nu>,
"Bhumika Goyal" <bhumirks@gmail.com>,
"Markus Elfring" <elfring@users.sourceforge.net>,
"Arvind Yadav" <arvind.yadav.cs@gmail.com>,
"Julia Lawall" <Julia.Lawall@lip6.fr>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Santosh Kumar Singh" <kumar.san1093@gmail.com>
Subject: Re: [PATCH v2 4/7] media: usb: add SPDX identifiers to some code I wrote
Date: Fri, 1 Dec 2017 15:52:55 +0200 [thread overview]
Message-ID: <20171201135255.vc5duelcqc7n52hm@paasikivi.fi.intel.com> (raw)
In-Reply-To: <e3c101aab92fa400f6ac532b39cdf82b39be6784.1512135871.git.mchehab@s-opensource.com>
Hi Mauro,
On Fri, Dec 01, 2017 at 11:47:10AM -0200, Mauro Carvalho Chehab wrote:
> diff --git a/drivers/media/usb/au0828/au0828-input.c b/drivers/media/usb/au0828/au0828-input.c
> index af68afe085b5..832ed9f25784 100644
> --- a/drivers/media/usb/au0828/au0828-input.c
> +++ b/drivers/media/usb/au0828/au0828-input.c
> @@ -1,21 +1,10 @@
> -/*
> - handle au0828 IR remotes via linux kernel input layer.
> -
> - Copyright (C) 2014 Mauro Carvalho Chehab <mchehab@samsung.com>
> - Copyright (c) 2014 Samsung Electronics Co., Ltd.
> -
> - Based on em28xx-input.c.
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// handle au0828 IR remotes via linux kernel input layer.
> +//
> +// Copyright (c) 2014 Mauro Carvalho Chehab <mchehab@samsung.com>
> +// Copyright (c) 2014 Samsung Electronics Co., Ltd.
> +//
> +// Based on em28xx-input.c.
Is the intention really to use C++ comments? I see that the SPDX license
identifiers elsewhere use C comments.
--
Kind regards,
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2017-12-01 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 13:47 [PATCH v2 1/7] edac: adjust GPLv2 license and SPDX identifiers at the code I wrote Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 2/7] media: rc: add SPDX identifiers to " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 3/7] media: tuners: " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 4/7] media: usb: add SPDX identifiers to some " Mauro Carvalho Chehab
2017-12-01 13:52 ` Sakari Ailus [this message]
2017-12-01 13:59 ` Mauro Carvalho Chehab
2017-12-01 14:32 ` Sakari Ailus
2017-12-12 7:08 ` Andi Shyti
2017-12-01 13:47 ` [PATCH v2 5/7] media: rc keymaps: add SPDX identifiers to the " Mauro Carvalho Chehab
2017-12-01 13:47 ` [PATCH v2 6/7] media: i2c: " Mauro Carvalho Chehab
2017-12-01 14:33 ` Sakari Ailus
2017-12-01 13:47 ` [PATCH v2 7/7] media: siano: add SPDX markups Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201135255.vc5duelcqc7n52hm@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andi.shyti@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhumirks@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=colin.king@canonical.com \
--cc=david@hardeman.nu \
--cc=elfring@users.sourceforge.net \
--cc=hans.verkuil@cisco.com \
--cc=kumar.san1093@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=lkml@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@s-opensource.com \
--cc=pombredanne@nexb.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).