linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Jaedon Shin <jaedon.shin@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
	Colin Ian King <colin.king@canonical.com>,
	Satendra Singh Thakur <satendra.t@samsung.com>,
	linux-media@vger.kernel.org,
	Michael Ira Krufky <mkrufky@linuxtv.org>,
	Sean Young <sean@mess.org>
Subject: Re: [PATCH 0/3] Add support compat in dvb_frontend.c
Date: Sat, 2 Dec 2017 05:50:47 -0200	[thread overview]
Message-ID: <20171202055047.7613db42@vento.lan> (raw)
In-Reply-To: <20171201123130.23128-1-jaedon.shin@gmail.com>

Hi Jaedon,

Em Fri,  1 Dec 2017 21:31:27 +0900
Jaedon Shin <jaedon.shin@gmail.com> escreveu:

> This patch series supports compat ioctl for 32-bit user space applications
> in 64-bit system.
> 
> Jaedon Shin (3):
>   media: dvb_frontend: Add unlocked_ioctl in dvb_frontend.c
>   media: dvb_frontend: Add compat_ioctl callback
>   media: dvb_frontend: Add commands implementation for compat ioct

Thanks for the series. Yeah, indeed we need something like that.

Yet, I suspect that you should also move the logic inside
dvb_frontend_handle_ioctl() with copies from/to userspace.

We don't want the logic there to be called when a 32-bit userspace
copy happens, as it should now use the new compat32 code.


Thanks,
Mauro

  parent reply	other threads:[~2017-12-02  7:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 12:31 [PATCH 0/3] Add support compat in dvb_frontend.c Jaedon Shin
2017-12-01 12:31 ` [PATCH 1/3] media: dvb_frontend: Add unlocked_ioctl " Jaedon Shin
2017-12-01 12:31 ` [PATCH 2/3] media: dvb_frontend: Add compat_ioctl callback Jaedon Shin
2017-12-04 14:29   ` kbuild test robot
2017-12-01 12:31 ` [PATCH 3/3] media: dvb_frontend: Add commands implementation for compat ioct Jaedon Shin
2017-12-04 12:56   ` kbuild test robot
2017-12-04 13:46   ` Menion
2017-12-04 18:33   ` kbuild test robot
2017-12-02  7:50 ` Mauro Carvalho Chehab [this message]
2017-12-13 14:30   ` [PATCH 0/3] Add support compat in dvb_frontend.c Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202055047.7613db42@vento.lan \
    --to=mchehab@kernel.org \
    --cc=colin.king@canonical.com \
    --cc=jaedon.shin@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=satendra.t@samsung.com \
    --cc=sean@mess.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).