linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, rajmohan.mani@intel.com, yong.zhi@intel.com
Subject: Re: [RESEND GIT PULL for 4.16] Intel IPU3 CIO2 CSI-2 receiver driver
Date: Fri, 8 Dec 2017 12:59:37 -0200	[thread overview]
Message-ID: <20171208125937.07bb3302@vento.lan> (raw)
In-Reply-To: <20171201143135.c6r2e2iaoxcvyxpi@valkosipuli.retiisi.org.uk>

Em Fri, 1 Dec 2017 16:31:36 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:

> Hi Mauro,
> 
> Here's the Intel IPU3 CIO2 CSI-2 receiver driver, with the accompanying
> format definitions.

This patch generates two warnings:

drivers/media/pci/intel/ipu3/ipu3-cio2.c:1899:16: warning: Variable length array is used.
drivers/media/pci/intel/ipu3/ipu3-cio2.c: In function 'cio2_pci_probe':
drivers/media/pci/intel/ipu3/ipu3-cio2.c:1726:14: warning: variable 'phys' set but not used [-Wunused-but-set-variable]
  phys_addr_t phys;
              ^~~~

We should never use variable-length array on Kernel, as Linux stack
is very limited, and we have static analyzers to check for it at
compilation time.

Also, the logic should check if pci_resource_start() succeeded, instead
of just ignoring it.

Please fix.


> 
> Please pull.
> 
> 
> The following changes since commit be9b53c83792e3898755dce90f8c632d40e7c83e:
> 
>   media: dvb-frontends: complete kernel-doc markups (2017-11-30 04:19:05 -0500)
> 
> are available in the git repository at:
> 
>   ssh://linuxtv.org/git/sailus/media_tree.git ipu3
> 
> for you to fetch changes up to f178207daa68e817ab6fd702d81ed7c8637ab72c:
> 
>   intel-ipu3: cio2: add new MIPI-CSI2 driver (2017-11-30 14:19:47 +0200)
> 
> ----------------------------------------------------------------
> Yong Zhi (3):
>       videodev2.h, v4l2-ioctl: add IPU3 raw10 color format
>       doc-rst: add IPU3 raw10 bayer pixel format definitions
>       intel-ipu3: cio2: add new MIPI-CSI2 driver
> 
>  Documentation/media/uapi/v4l/pixfmt-rgb.rst        |    1 +
>  .../media/uapi/v4l/pixfmt-srggb10-ipu3.rst         |  335 ++++
>  MAINTAINERS                                        |    8 +
>  drivers/media/pci/Kconfig                          |    2 +
>  drivers/media/pci/Makefile                         |    3 +-
>  drivers/media/pci/intel/Makefile                   |    5 +
>  drivers/media/pci/intel/ipu3/Kconfig               |   19 +
>  drivers/media/pci/intel/ipu3/Makefile              |    1 +
>  drivers/media/pci/intel/ipu3/ipu3-cio2.c           | 2052 ++++++++++++++++++++
>  drivers/media/pci/intel/ipu3/ipu3-cio2.h           |  449 +++++
>  drivers/media/v4l2-core/v4l2-ioctl.c               |    4 +
>  include/uapi/linux/videodev2.h                     |    6 +
>  12 files changed, 2884 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst
>  create mode 100644 drivers/media/pci/intel/Makefile
>  create mode 100644 drivers/media/pci/intel/ipu3/Kconfig
>  create mode 100644 drivers/media/pci/intel/ipu3/Makefile
>  create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.c
>  create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.h
> 



Thanks,
Mauro

  reply	other threads:[~2017-12-08 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 14:31 [RESEND GIT PULL for 4.16] Intel IPU3 CIO2 CSI-2 receiver driver Sakari Ailus
2017-12-08 14:59 ` Mauro Carvalho Chehab [this message]
2017-12-08 23:32   ` Zhi, Yong
2017-12-15 15:18     ` Zhi, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208125937.07bb3302@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=sakari.ailus@iki.fi \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).