From: jacopo mondi <jacopo@jmondi.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
laurent.pinchart@ideasonboard.com, magnus.damm@gmail.com,
geert@glider.be, hverkuil@xs4all.nl, mchehab@kernel.org,
festevam@gmail.com, sakari.ailus@iki.fi, robh+dt@kernel.org,
mark.rutland@arm.com, pombredanne@nexb.com,
linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver
Date: Sun, 21 Jan 2018 18:54:45 +0100 [thread overview]
Message-ID: <20180121175445.GQ24926@w540> (raw)
In-Reply-To: <b26ef29e-0c26-6359-1205-735e6770eb10@infradead.org>
Hi Randy,
thanks for noticing,
On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote:
> On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
> > Hello,
> > new version of CEU after Hans' review.
> >
> > Added his Acked-by to most patches and closed review comments.
> > Running v4l2-compliance, I noticed a new failure introduced by the way I now
> > calculate the plane sizes in set/try_fmt.
>
> I would expect that you have already seen this, but I get a build error
> in renesas-ceu.c. Here is a small patch for it.
Actually I did not.
The compile error has been introduced by this commit
commit 4e48afecd5ee3a394d228349fc1c33982e9fb557
Author: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Date: Wed Sep 27 10:12:00 2017 -0400
media: v4l2-async: simplify v4l2_async_subdev structure
Which is not in v4.15-rc8 on which I have based my work on.
As a general question, if I'm aiming to have my driver included in
next release, should I always base my work on linux-next or it depends
on sub-system/maintainers preferences?
Thanks
j
>
> ---
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build error (on x86 with COMPILE_TEST):
>
> ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt':
> ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union
> ceu_sd->asd.match.fwnode.fwnode =
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/media/platform/renesas-ceu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c
> +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c
> @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic
>
> ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;
> ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
> - ceu_sd->asd.match.fwnode.fwnode =
> + ceu_sd->asd.match.fwnode =
> fwnode_graph_get_remote_port_parent(
> of_fwnode_handle(ep));
>
>
next prev parent reply other threads:[~2018-01-21 17:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 21:44 [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings Jacopo Mondi
2018-01-17 7:59 ` Sakari Ailus
2018-01-17 8:35 ` jacopo mondi
2018-01-17 8:55 ` Sakari Ailus
2018-01-16 21:44 ` [PATCH v6 2/9] include: media: Add Renesas CEU driver interface Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver Jacopo Mondi
2018-01-19 11:20 ` Hans Verkuil
2018-01-19 12:20 ` Laurent Pinchart
2018-01-19 12:25 ` Hans Verkuil
2018-01-22 0:52 ` Laurent Pinchart
2018-01-22 9:07 ` Hans Verkuil
2018-01-21 9:53 ` jacopo mondi
2018-01-21 10:21 ` Hans Verkuil
2018-01-21 10:23 ` Hans Verkuil
2018-01-21 17:29 ` jacopo mondi
2018-01-22 9:56 ` Hans Verkuil
2018-01-19 22:35 ` kbuild test robot
2018-01-20 2:11 ` kbuild test robot
2018-01-16 21:44 ` [PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver Jacopo Mondi
2018-01-16 21:44 ` [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Jacopo Mondi
2018-01-19 10:24 ` Hans Verkuil
2018-01-19 10:47 ` Hans Verkuil
2018-01-19 11:19 ` Sakari Ailus
2018-01-19 11:44 ` Hans Verkuil
2018-01-19 12:23 ` Laurent Pinchart
2018-01-21 9:31 ` jacopo mondi
2018-01-21 10:18 ` Hans Verkuil
2018-01-16 21:44 ` [PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies Jacopo Mondi
2018-01-16 21:45 ` [PATCH v6 9/9] arch: sh: migor: Use new renesas-ceu camera driver Jacopo Mondi
2018-01-19 11:26 ` [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Hans Verkuil
2018-01-21 17:49 ` jacopo mondi
2018-01-22 10:00 ` Hans Verkuil
2018-01-19 22:12 ` Randy Dunlap
2018-01-21 17:54 ` jacopo mondi [this message]
2018-01-21 18:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180121175445.GQ24926@w540 \
--to=jacopo@jmondi.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert@glider.be \
--cc=hverkuil@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pombredanne@nexb.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).