From: Daniel Scheller <d.scheller.oss@gmail.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org,
mchehab@s-opensource.com
Subject: [PATCH v2 00/12] ngene-updates: Hardware support, TS buffer shift fix
Date: Sun, 25 Feb 2018 13:31:28 +0100 [thread overview]
Message-ID: <20180225123140.19486-1-d.scheller.oss@gmail.com> (raw)
From: Daniel Scheller <d.scheller@gmx.net>
Sorry for this quick V2 of this series and thus sorry for the traffic,
spam and noise. V1 missed a 188-byte clamping in tsin_find_offset() and
a recheck for the remaining size of the TS buffer to copy after offset
correction.
Some love for the ngene driver, which runs the older Micronas nGene
based cards from Digital Devices like the cineS2 v5.5.
This series changes:
- Two more PCI IDs for more supported PCIe bridge hardware
- Conversion of all printk() to more proper dev_*() based logging (the
module_init rather uses pr_*() logging since there's no *dev available
yet).
- Support for all available DuoFlex addon modules from that vendor. All
addon modules are electrically compatible and use the same interface,
and the addons work very well on the aging ngene hardware.
- Check for CXD2099AR addon modules before blindly trying to attach them,
removing unnecessary and maybe irritating error logging if such module
isn't present.
- Workaround a hardware quirk in conjunction with the CXD2099AR module,
CA modules and CAM control communication, causing the TS input buffer
to shift albeit different communication paths are ought to be in use.
This series is based on the CXD2099 regmap conversion series, see [1].
Especially [2] is required for the STV0367 enablement patch (and the
following ones) since the use of the TDA18212 I2C tuner client relies
on the i2c_client variable to be present, which is added in the
forementioned CXD2099 series.
Please pick this up and merge.
[1] https://www.spinics.net/lists/linux-media/msg129183.html
[2] https://www.spinics.net/lists/linux-media/msg129187.html
Changes since v1:
- TS buffer offset correction missed a check for the remaining buffer
length before copying the next full 188-byte block, which might could
have caused out-of-bound-reads from void *buf. Also, tsin_find_offset
returns it's offset clamped to 188 byte boundaries to not accidentally
skip over valid TS data. Few typos in the commit message were fixed
and a note for the modparam was added, too.
Daniel Scheller (12):
[media] ngene: add two additional PCI IDs
[media] ngene: convert kernellog printing from printk() to dev_*()
macros
[media] ngene: use defines to identify the demod_type
[media] ngene: support STV0367 DVB-C/T DuoFlex addons
[media] ngene: add XO2 module support
[media] ngene: add support for Sony CXD28xx-based DuoFlex modules
[media] ngene: add support for DuoFlex S2 V4 addon modules
[media] ngene: deduplicate I2C adapter evaluation
[media] ngene: check for CXD2099AR presence before attaching
[media] ngene: don't treat non-existing demods as error
[media] ngene: move the tsin_exchange() stripcopy block into a
function
[media] ngene: compensate for TS buffer offset shifts
drivers/media/pci/ngene/Kconfig | 6 +
drivers/media/pci/ngene/ngene-cards.c | 590 ++++++++++++++++++++++++++++++----
drivers/media/pci/ngene/ngene-core.c | 101 +++---
drivers/media/pci/ngene/ngene-dvb.c | 133 ++++++--
drivers/media/pci/ngene/ngene.h | 23 ++
5 files changed, 732 insertions(+), 121 deletions(-)
--
2.16.1
next reply other threads:[~2018-02-25 12:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 12:31 Daniel Scheller [this message]
2018-02-25 12:31 ` [PATCH v2 01/12] [media] ngene: add two additional PCI IDs Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 02/12] [media] ngene: convert kernellog printing from printk() to dev_*() macros Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 03/12] [media] ngene: use defines to identify the demod_type Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 04/12] [media] ngene: support STV0367 DVB-C/T DuoFlex addons Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 05/12] [media] ngene: add XO2 module support Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 06/12] [media] ngene: add support for Sony CXD28xx-based DuoFlex modules Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 07/12] [media] ngene: add support for DuoFlex S2 V4 addon modules Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation Daniel Scheller
2018-03-06 16:06 ` Mauro Carvalho Chehab
2018-03-06 16:14 ` Mauro Carvalho Chehab
2018-02-25 12:31 ` [PATCH v2 09/12] [media] ngene: check for CXD2099AR presence before attaching Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 10/12] [media] ngene: don't treat non-existing demods as error Daniel Scheller
2018-02-25 12:31 ` [PATCH v2 11/12] [media] ngene: move the tsin_exchange() stripcopy block into a function Daniel Scheller
2018-03-06 16:18 ` Mauro Carvalho Chehab
2018-02-25 12:31 ` [PATCH v2 12/12] [media] ngene: compensate for TS buffer offset shifts Daniel Scheller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180225123140.19486-1-d.scheller.oss@gmail.com \
--to=d.scheller.oss@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).