From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from casper.infradead.org ([85.118.1.10]:36022 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbeKBWM5 (ORCPT ); Fri, 2 Nov 2018 18:12:57 -0400 Date: Fri, 2 Nov 2018 10:05:42 -0300 From: Mauro Carvalho Chehab To: Yong Zhi Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, tfiga@chromium.org, hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com, rajmohan.mani@intel.com, jian.xu.zheng@intel.com, jerry.w.hu@intel.com, tuukka.toivonen@intel.com, tian.shu.qiu@intel.com, bingbu.cao@intel.com Subject: Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats Message-ID: <20181102100542.494dec47@coco.lan> In-Reply-To: <20181102095909.7676482b@coco.lan> References: <1540851790-1777-1-git-send-email-yong.zhi@intel.com> <1540851790-1777-2-git-send-email-yong.zhi@intel.com> <20181102095909.7676482b@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Fri, 2 Nov 2018 09:59:31 -0300 Mauro Carvalho Chehab escreveu: > Hi Zhi-san, > > Em Mon, 29 Oct 2018 15:22:55 -0700 > Yong Zhi escreveu: > > > Add IPU3-specific meta formats for parameter > > processing and 3A, DVS statistics: > > > > V4L2_META_FMT_IPU3_PARAMS > > V4L2_META_FMT_IPU3_STAT_3A > > > > Signed-off-by: Yong Zhi > > --- > > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > > include/uapi/linux/videodev2.h | 4 ++++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > > index 6489f25..abff64b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1299,6 +1299,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > case V4L2_META_FMT_VSP1_HGO: descr = "R-Car VSP1 1-D Histogram"; break; > > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; break; > > case V4L2_META_FMT_UVC: descr = "UVC payload header metadata"; break; > > + case V4L2_META_FMT_IPU3_PARAMS: descr = "IPU3 processing parameters"; break; > > + case V4L2_META_FMT_IPU3_STAT_3A: descr = "IPU3 3A statistics"; break; > > > > default: > > /* Compressed formats */ > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index f0a968a..bdccd7a 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -718,6 +718,10 @@ struct v4l2_pix_format { > > #define V4L2_META_FMT_UVC v4l2_fourcc('U', 'V', 'C', 'H') /* UVC Payload Header metadata */ > > #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > > > > +/* Vendor specific - used for IPU3 camera sub-system */ > > +#define V4L2_META_FMT_IPU3_PARAMS v4l2_fourcc('i', 'p', '3', 'p') /* IPU3 params */ > > +#define V4L2_META_FMT_IPU3_STAT_3A v4l2_fourcc('i', 'p', '3', 's') /* IPU3 3A statistics */ > > Where's the documentation for those two new formats? The best is to > always add the documentation bits for V4L2 uAPI stuff at the same > patch, as it makes easier for us to review. Found it. It is at patch 3. > > > + > > /* priv field value to indicates that subsequent fields are valid. */ > > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > > > > > > Thanks, > Mauro Thanks, Mauro