From: Ezequiel Garcia <ezequiel@collabora.com>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH] v4l2-compliance: Remove spurious error messages
Date: Mon, 19 Nov 2018 12:17:43 -0300 [thread overview]
Message-ID: <20181119151743.27275-1-ezequiel@collabora.com> (raw)
Get rid of a couple confusing error messages, namely:
test VIDIOC_G_FMT: OK
fail: v4l2-test-formats.cpp(464): pix_mp.plane_fmt[0].reserved not zeroed
fail: v4l2-test-formats.cpp(752): Video Output Multiplanar is valid, but TRY_FMT failed to return a format
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(464): pix_mp.plane_fmt[0].reserved not zeroed
fail: v4l2-test-formats.cpp(1017): Video Output Multiplanar is valid, but no S_FMT was implemented
test VIDIOC_S_FMT: FAI
Where only the first message "pix_mp.plane_fmt[0].reserved not zeroed"
is accurate.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
utils/v4l2-compliance/v4l2-test-formats.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
index 2fb811ad5eb4..006cc3222c65 100644
--- a/utils/v4l2-compliance/v4l2-test-formats.cpp
+++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
@@ -748,8 +748,7 @@ int testTryFormats(struct node *node)
}
ret = testFormatsType(node, ret, type, fmt, true);
if (ret)
- return fail("%s is valid, but TRY_FMT failed to return a format\n",
- buftype2s(type).c_str());
+ return ret;
}
memset(&fmt, 0, sizeof(fmt));
@@ -1013,8 +1012,7 @@ int testSetFormats(struct node *node)
}
ret = testFormatsType(node, ret, type, fmt_set, true);
if (ret)
- return fail("%s is valid, but no S_FMT was implemented\n",
- buftype2s(type).c_str());
+ return ret;
fmt_set = fmt;
ret = doioctl(node, VIDIOC_S_FMT, &fmt_set);
--
2.19.1
reply other threads:[~2018-11-20 1:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119151743.27275-1-ezequiel@collabora.com \
--to=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).