From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
mchehab@kernel.org, linux-media@vger.kernel.org,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v2 for v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation
Date: Mon, 26 Nov 2018 08:32:20 +0100 [thread overview]
Message-ID: <20181126073220.GC18375@kroah.com> (raw)
In-Reply-To: <20181114093753.29081-1-sakari.ailus@linux.intel.com>
On Wed, Nov 14, 2018 at 11:37:53AM +0200, Sakari Ailus wrote:
> [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ]
>
> Patch ad608fbcf166 changed how events were subscribed to address an issue
> elsewhere. As a side effect of that change, the "add" callback was called
> before the event subscription was added to the list of subscribed events,
> causing the first event queued by the add callback (and possibly other
> events arriving soon afterwards) to be lost.
>
> Fix this by adding the subscription to the list before calling the "add"
> callback, and clean up afterwards if that fails.
>
> Fixes: ad608fbcf166 ("media: v4l: event: Prevent freeing event subscriptions while accessed")
>
> Reported-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Tested-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
> Tested-by: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> [Sakari Ailus: Backported to v4.9 stable]
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> since v1 (as requested by Sasha):
>
> - Add my final SoB
> - Indicate specifically this is a backport
> - Remove the extra cc stable
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2018-11-26 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 9:37 [PATCH v2 for v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation Sakari Ailus
2018-11-26 7:32 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126073220.GC18375@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dave.stevenson@raspberrypi.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).