From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-media@vger.kernel.org, Leon Luo <leonl@leopardimaging.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: imx274: don't declare events, they are not implemented
Date: Tue, 27 Nov 2018 10:38:59 +0200 [thread overview]
Message-ID: <20181127083859.zljff4wk4hikel56@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20181127083445.27737-1-luca@lucaceresoli.net>
Hi Luca,
On Tue, Nov 27, 2018 at 09:34:43AM +0100, Luca Ceresoli wrote:
> The V4L2_SUBDEV_FL_HAS_EVENTS flag should not be set, event are just
> not implemented.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
The driver supports controls, and so control events can be subscribed and
received by the user. Therefore I don't see a reason to remove the flag.
> ---
> drivers/media/i2c/imx274.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
> index 95a0e7d9851a..78746c51071d 100644
> --- a/drivers/media/i2c/imx274.c
> +++ b/drivers/media/i2c/imx274.c
> @@ -1878,7 +1878,7 @@ static int imx274_probe(struct i2c_client *client,
> imx274->client = client;
> sd = &imx274->sd;
> v4l2_i2c_subdev_init(sd, client, &imx274_subdev_ops);
> - sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
> + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
>
> /* initialize subdev media pad */
> imx274->pad.flags = MEDIA_PAD_FL_SOURCE;
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2018-11-27 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 8:34 [PATCH 1/3] media: imx274: don't declare events, they are not implemented Luca Ceresoli
2018-11-27 8:34 ` [PATCH 2/3] media: imx274: declare the correct number of controls Luca Ceresoli
2018-11-27 8:34 ` [PATCH 3/3] media: imx274: select REGMAP_I2C Luca Ceresoli
2018-11-27 8:38 ` Sakari Ailus [this message]
2018-11-27 9:09 ` [PATCH 1/3] media: imx274: don't declare events, they are not implemented Luca Ceresoli
2018-11-27 9:19 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127083859.zljff4wk4hikel56@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=leonl@leopardimaging.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).