From: Marco Felsch <m.felsch@pengutronix.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
enrico.scholz@sigma-chemnitz.de, devicetree@vger.kernel.org,
akinobu.mita@gmail.com, linux-media@vger.kernel.org,
graphics@pengutronix.de
Subject: Re: [PATCH v3 5/6] dt-bindings: media: mt9m111: add pclk-sample property
Date: Tue, 27 Nov 2018 15:21:05 +0100 [thread overview]
Message-ID: <20181127142105.4jb6hlojiu54ipux@pengutronix.de> (raw)
In-Reply-To: <20181127131320.ejzau4mjqhunlfvu@paasikivi.fi.intel.com>
Hi Sakari,
On 18-11-27 15:13, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Nov 27, 2018 at 11:02:52AM +0100, Marco Felsch wrote:
> > Add the pclk-sample property to the list of optional properties
> > for the mt9m111 camera sensor.
> >
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> > index a431fb45704b..d0bed6fa901a 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> > @@ -14,6 +14,10 @@ sub-node for its digital output video port, in accordance with the video
> > interface bindings defined in:
> > Documentation/devicetree/bindings/media/video-interfaces.txt
> >
> > +Optional endpoint properties:
> > +- pclk-sample: For information see ../video-interfaces.txt. The value is set to
> > + 0 if it isn't specified.
>
> How about the data-active, hsync-active and vsync-active properties? Does
> the hardware have a fixed configuration, or can this be set? It appears the
> driver assumes active high for all.
As I understood it correctly the data-active, hsync-active and vsync-active
I/O lines are always ACTIVE_HIGH.
Kind regards,
Marco
> If there's something to change, this should be a separate patch IMO.
>
> > +
> > Example:
> >
> > i2c_master {
> > @@ -26,6 +30,7 @@ Example:
> > port {
> > mt9m111_1: endpoint {
> > remote-endpoint = <&pxa_camera>;
> > + pclk-sample = <1>;
> > };
> > };
> > };
>
> --
> Sakari Ailus
> sakari.ailus@linux.intel.com
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2018-11-28 1:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 10:02 [PATCH v3 0/6] media: mt9m111 features Marco Felsch
2018-11-27 10:02 ` [PATCH v3 1/6] media: mt9m111: add s_stream callback Marco Felsch
2018-11-27 10:02 ` [PATCH v3 2/6] media: mt9m111: add streaming check to set_fmt Marco Felsch
2018-11-27 10:02 ` [PATCH v3 3/6] media: mt9m111: add support to select formats and fps for {Q,SXGA} Marco Felsch
2018-11-27 10:02 ` [PATCH v3 4/6] dt-bindings: media: mt9m111: adapt documentation to be more clear Marco Felsch
2018-11-27 10:02 ` [PATCH v3 5/6] dt-bindings: media: mt9m111: add pclk-sample property Marco Felsch
2018-11-27 13:13 ` Sakari Ailus
2018-11-27 14:21 ` Marco Felsch [this message]
2018-11-27 15:57 ` Sakari Ailus
2018-11-27 10:02 ` [PATCH v3 6/6] media: mt9m111: allow to setup pixclk polarity Marco Felsch
2018-11-27 13:19 ` Sakari Ailus
2018-11-27 13:39 ` Philipp Zabel
2018-11-27 13:50 ` Sakari Ailus
2018-11-27 14:12 ` Philipp Zabel
2018-11-27 16:00 ` Sakari Ailus
2018-11-27 13:47 ` Marco Felsch
2018-11-27 21:15 ` Sakari Ailus
2018-11-28 8:29 ` Marco Felsch
2018-11-28 9:05 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127142105.4jb6hlojiu54ipux@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=akinobu.mita@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=graphics@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).