From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Priit Laes <plaes@plaes.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: Kconfig: Add configuration entry for MEDIA_MEM2MEM_SUPPORT
Date: Wed, 5 Dec 2018 17:47:03 -0200 [thread overview]
Message-ID: <20181205174703.5d2a8529@coco.lan> (raw)
In-Reply-To: <20181126163844.18729-1-plaes@plaes.org>
Em Mon, 26 Nov 2018 18:38:44 +0200
Priit Laes <plaes@plaes.org> escreveu:
> Currently there is no easy way to enable mem2mem based video
> processor drivers (cedrus for example). Simplify this by adding
> separate category to media support.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
> drivers/media/Kconfig | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 8add62a18293..f2a773896dcf 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -56,6 +56,14 @@ config MEDIA_DIGITAL_TV_SUPPORT
> Say Y when you have a board with digital support or a board with
> hybrid digital TV and analog TV.
>
> +config MEDIA_MEM2MEM_SUPPORT
> + bool "Mem2mem devices (stateless media decoders/encoders support)"
> + ---help---
> + Enable support for mem2mem / stateless media decoders/encoders.
> +
> + Say Y when you have a system with stateless media encoder/decoder
> + support.
> +
> config MEDIA_RADIO_SUPPORT
> bool "AM/FM radio receivers/transmitters support"
> ---help---
> @@ -95,7 +103,7 @@ source "drivers/media/cec/Kconfig"
>
> config MEDIA_CONTROLLER
> bool "Media Controller API"
> - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
> + depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_MEM2MEM_SUPPORT
> ---help---
> Enable the media controller API used to query media devices internal
> topology and configure it dynamically.
> @@ -118,7 +126,7 @@ config MEDIA_CONTROLLER_DVB
> config VIDEO_DEV
> tristate
> depends on MEDIA_SUPPORT
> - depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
> + depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT || MEDIA_MEM2MEM_SUPPORT
> default y
>
> config VIDEO_V4L2_SUBDEV_API
Hmm... this patch looks incomplete. I mean, the main goal of those
MEDIA_*_SUPPORT is to make simpler for the users to select a
subset of the drivers. Those options actually make visible
the corresponding entries for pci/usb/... drivers. So,
for example, drivers/media/usb/Kconfig contains:
if MEDIA_CAMERA_SUPPORT
comment "Webcam devices"
source "drivers/media/usb/uvc/Kconfig"
source "drivers/media/usb/gspca/Kconfig"
source "drivers/media/usb/pwc/Kconfig"
source "drivers/media/usb/cpia2/Kconfig"
source "drivers/media/usb/zr364xx/Kconfig"
source "drivers/media/usb/stkwebcam/Kconfig"
source "drivers/media/usb/s2255/Kconfig"
source "drivers/media/usb/usbtv/Kconfig"
endif
If we'll be adding it, I would expect a corresponding change at
drivers/media/platform/Kconfig.
Thanks,
Mauro
next prev parent reply other threads:[~2018-12-05 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:38 [PATCH] media: Kconfig: Add configuration entry for MEDIA_MEM2MEM_SUPPORT Priit Laes
2018-12-05 19:47 ` Mauro Carvalho Chehab [this message]
2018-12-06 2:15 ` Priit Laes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205174703.5d2a8529@coco.lan \
--to=mchehab@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=plaes@plaes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).