From: kbuild test robot <lkp@intel.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
hverkuil@xs4all.nl, mchehab@kernel.org,
lkcamp@lists.libreplanetbr.org, kernel@collabora.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: vimc: add configfs API to configure the topology
Date: Sat, 8 Dec 2018 16:03:27 +0800 [thread overview]
Message-ID: <201812081641.Qe7Y1urI%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181207182200.25283-1-helen.koike@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 4914 bytes --]
Hi Helen,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Helen-Koike/media-vimc-add-configfs-API-to-configure-the-topology/20181208-071726
base: git://linuxtv.org/media_tree.git master
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/module.h:9,
from drivers/media//platform/vimc/vimc-configfs.c:9:
drivers/media//platform/vimc/vimc-configfs.c: In function 'vimc_cfs_link_make_item':
include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
#define KERN_ERR KERN_SOH "3" /* error conditions */
^~~~~~~~
include/linux/printk.h:308:9: note: in expansion of macro 'KERN_ERR'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~
>> drivers/media//platform/vimc/vimc-configfs.c:22:2: note: in expansion of macro 'pr_err'
pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__)
^~~~~~
>> drivers/media//platform/vimc/vimc-configfs.c:23:25: note: in expansion of macro 'ci_err'
#define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__)
^~~~~~
>> drivers/media//platform/vimc/vimc-configfs.c:323:3: note: in expansion of macro 'cg_err'
cg_err(&cfs->gdev,
^~~~~~
drivers/media//platform/vimc/vimc-configfs.c:324:32: note: format string is defined here
"Pad with more then %ld digits is not supported",
~~^
%d
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/module.h:9,
from drivers/media//platform/vimc/vimc-configfs.c:9:
drivers/media//platform/vimc/vimc-configfs.c: In function 'vimc_cfs_ent_make_group':
include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'unsigned int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH'
#define KERN_ERR KERN_SOH "3" /* error conditions */
^~~~~~~~
include/linux/printk.h:308:9: note: in expansion of macro 'KERN_ERR'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~
>> drivers/media//platform/vimc/vimc-configfs.c:22:2: note: in expansion of macro 'pr_err'
pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__)
^~~~~~
>> drivers/media//platform/vimc/vimc-configfs.c:23:25: note: in expansion of macro 'ci_err'
#define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__)
^~~~~~
drivers/media//platform/vimc/vimc-configfs.c:443:3: note: in expansion of macro 'cg_err'
cg_err(&cfs->gdev,
^~~~~~
drivers/media//platform/vimc/vimc-configfs.c:444:56: note: format string is defined here
"%s: Driver name length should be less then %ld.",
~~^
%d
vim +/pr_err +22 drivers/media//platform/vimc/vimc-configfs.c
20
21 #define ci_err(ci, fmt, ...) \
> 22 pr_err("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__)
> 23 #define cg_err(cg, ...) ci_err(&(cg)->cg_item, ##__VA_ARGS__)
24 #define ci_warn(ci, fmt, ...) \
25 pr_warn("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__)
26 #define cg_warn(cg, ...) ci_warn(&(cg)->cg_item, ##__VA_ARGS__)
27 #define ci_dbg(ci, fmt, ...) \
28 pr_debug("vimc: %s: " pr_fmt(fmt), (ci)->ci_name, ##__VA_ARGS__)
29 #define cg_dbg(cg, ...) ci_dbg(&(cg)->cg_item, ##__VA_ARGS__)
30
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67842 bytes --]
next prev parent reply other threads:[~2018-12-08 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 18:22 [PATCH] media: vimc: add configfs API to configure the topology Helen Koike
2018-12-08 8:03 ` kbuild test robot [this message]
2018-12-10 11:31 ` Hans Verkuil
2018-12-10 16:14 ` Helen Koike
2018-12-10 17:13 ` Hans Verkuil
2019-08-10 7:40 ` Dafna Hirschfeld
2019-08-13 13:02 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812081641.Qe7Y1urI%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@01.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).