From: jacopo mondi <jacopo@jmondi.org>
To: sakari.ailus@iki.fi
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
corbet@lwn.net, mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4l2: i2c: ov7670: Fix PLL bypass register values
Date: Mon, 10 Dec 2018 08:59:02 +0100 [thread overview]
Message-ID: <20181210075902.GG5597@w540> (raw)
In-Reply-To: <20181209233917.dhtwrpb46y2iyx4m@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]
Hi Sakari,
thanks for digging this out
On Mon, Dec 10, 2018 at 01:39:17AM +0200, sakari.ailus@iki.fi wrote:
> Hi Jacopo,
>
> On Fri, Dec 29, 2017 at 01:22:26PM +0100, Jacopo Mondi wrote:
> > The following commits:
> > commit f6dd927f34d6 ("[media] media: ov7670: calculate framerate properly for ov7675")
> > commit 04ee6d92047e ("[media] media: ov7670: add possibility to bypass pll for ov7675")
> > introduced the ability to bypass PLL multiplier and use input clock (xvclk)
> > as pixel clock output frequency for ov7675 sensor.
> >
> > PLL is bypassed using register DBLV[7:6], according to ov7670 and ov7675
> > sensor manuals. Macros used to set DBLV register seem wrong in the
> > driver, as their values do not match what reported in the datasheet.
> >
> > Fix by changing DBLV_* macros to use bits [7:6] and set bits [3:0] to
> > default 0x0a reserved value (according to datasheets).
> >
> > While at there, remove a write to DBLV register in
> > "ov7675_set_framerate()" that over-writes the previous one to the same
> > register that takes "info->pll_bypass" flag into account instead of setting PLL
> > multiplier to 4x unconditionally.
> >
> > And, while at there, since "info->pll_bypass" is only used in
> > set/get_framerate() functions used by ov7675 only, it is not necessary
> > to check for the device id at probe time to make sure that when using
> > ov7670 "info->pll_bypass" is set to false.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> I assume this is still valid and long overdue for merging. :-) No other
> work in the area seem to have been done so I'm picking it up...
>
It should still be valid, and should still apply regardless of its
age :) Is it worth a proper 'Fixes' tag?
Fixes: f6dd927f34d6 ("[media] media: ov7670: calculate framerate properly for ov7675")
Thanks
j
> --
> Regards,
>
> Sakari Ailus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2018-12-10 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 12:22 [PATCH] v4l2: i2c: ov7670: Fix PLL bypass register values Jacopo Mondi
2018-12-09 23:39 ` sakari.ailus
2018-12-10 7:59 ` jacopo mondi [this message]
2018-12-10 8:14 ` sakari.ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210075902.GG5597@w540 \
--to=jacopo@jmondi.org \
--cc=corbet@lwn.net \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).